public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Andi Kleen <ak@suse.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
	James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH] Improve pci_alloc_consistent wrapper on preemptive kernels
Date: Fri, 30 Jul 2004 14:07:57 -0400	[thread overview]
Message-ID: <410A8E7D.2030009@pobox.com> (raw)
In-Reply-To: <20040730194304.2c27f48c.ak@suse.de>

Andi Kleen wrote:
> On Fri, 30 Jul 2004 13:16:28 -0400
> Jeff Garzik <jgarzik@pobox.com> wrote:
> 
> 
> 
>>1) Changing from GFP_ATOMIC to <something else> may break code
> 
> 
> x86-64 did it for a long time and I am not aware of problems with it
> (however I don't know how widespread CONFIG_PREEMPT use on x86-64 is) 
> 
> 
>>2) Conversely from #1, I also worry why GFP_ATOMIC would be needed at 
>>all.  I code all my drivers to require that pci_alloc_consistent() be 
>>called from somewhere that is allowed to sleep.
> 
> 
> Maybe you do, but others don't.

Certainly.  Therefore, changing from GFP_ATOMIC will increase likelihood 
of breakage, no?

	Jeff




  reply	other threads:[~2004-07-30 18:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-30 17:02 [PATCH] Improve pci_alloc_consistent wrapper on preemptive kernels Andi Kleen
2004-07-30 17:16 ` Jeff Garzik
2004-07-30 17:43   ` Andi Kleen
2004-07-30 18:07     ` Jeff Garzik [this message]
2004-07-30 18:47       ` Takashi Iwai
2004-07-30 19:28         ` Takashi Iwai
2004-07-30 21:42       ` Andi Kleen
2004-07-30 20:02 ` Andrew Morton
2004-07-30 20:13   ` James Bottomley
2004-07-30 20:20     ` Andrew Morton
2004-07-30 20:28       ` James Bottomley
     [not found] <2nJ3t-34a-39@gated-at.bofh.it>
     [not found] ` <2nJmP-3eq-9@gated-at.bofh.it>
     [not found]   ` <2nJG8-3p6-21@gated-at.bofh.it>
     [not found]     ` <2nK9b-3PM-17@gated-at.bofh.it>
2004-07-30 18:34       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=410A8E7D.2030009@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox