Re: [PATCH] Configure IDE probe delays

Tim Bird
2004-08-02T21:56:48Z

Denis Vlasenko wrote:
> Crowd of "my old crapbox no longer boots with newer kernel, wtf?" people
> won't be happy at all.
>
> + ide_delay = simple_strtoul(s+10,NULL,0);
> + printk(" : Delay set to %dms\n", ide_delay);
> + return 1;
>
> Can we have a bit louder warning here?

We can make this even stronger if desired.

Alan Cox wrote:
> On Gwe, 2004-07-30 at 20:11, Todd Poynor wrote:
>
>>IDE initialization and probing makes numerous calls to sleep for 50
>>milliseconds while waiting for the interface to return probe status and
>>such.
>
>
> Please make it taint the kernel if you do that so we can ignore all the
> bug reports.

We can certainly make the warning louder as Denis suggests, and also
make the wording in the documentation stronger, like so...

+ "ide-delay=xx" : set delay in milliseconds for initialization and
+ probing. Defaults to 50ms. Use at your own risk. Please
+ do not report ANY problems to kernel developers if using a
+ non-default setting.

If needed, I'd be willing to taint the kernel to reduce the burden
of related bug reports. I'm a little concerned that tainting conveys
a meaning of GPL conformance questionability, which would not be the
case here. (Just configuration questionability... ;-)

This is primarily to support embedded systems with known hardware, but
I *DO* see the need to avoid having desktop people experiment with it
and make themselves (and by transitivity kernel developers) unhappy.

This is, admittedly, introducing a gun which one might use to shoot
one's own foot. However, in my testing these delays accounted
for about 70% of total kernel bootup time, and this is a pretty easy
way to "fix" it. I know many companies are very willing to bear
the burden of testing this out on their hardware before shipping
products (Sony would), in exchange for the dramatic bootup time
savings.

I'm still considering Jeff's comment, and I'll respond to that separately.

=============================
Tim Bird
Architecture Group Co-Chair, CE Linux Forum
Senior Staff Engineer, Sony Electronics
E-mail: tim.bird@am.sony.com
=============================