From: Jeff Garzik <jgarzik@pobox.com>
To: Willy Tarreau <willy@w.ods.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
greearb@candelatech.com, akpm@osdl.org, alan@redhat.com,
jgarzik@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: PATCH: VLAN support for 3c59x/3c90x
Date: Sat, 31 Jul 2004 12:26:05 -0400 [thread overview]
Message-ID: <410BC81D.3010105@pobox.com> (raw)
In-Reply-To: <20040731161234.GA27388@alpha.home.local>
Willy Tarreau wrote:
> On Sat, Jul 31, 2004 at 12:05:03PM -0400, Jeff Garzik wrote:
>
>>>Ok, sorry, I've just checked, they are 6. But I incidentely used the
>>>feature
>>>on 2 of them (dl2k and starfire). But more drivers still have the
>>>'static int mtu=1500' preceeded by a comment stating "allow the user to
>>>change
>>>the mtu". Why is it not a #define then, if nobody can change it anymore ?
>>
>>People can change it all the time with ifconfig.
>
>
> no, they change dev->mtu, not the 'static' mtu. I think it has been
Correct. The user _should not_ be allowed to change the driver limit,
because it is precisely that a driver (and hardware) limit.
> inherited from the old days without MODULE_PARM.
Using MODULE_PARM to select max MTU limit was always the wrong thing to
do. The user generally has no idea of the hardware limits involve.
Patches to remove these incorrect module parameters are welcome.
Jeff
next prev parent reply other threads:[~2004-07-31 16:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 12:42 PATCH: VLAN support for 3c59x/3c90x Alan Cox
2004-07-28 21:33 ` Ben Greear
2004-07-28 22:15 ` Alan Cox
2004-07-28 22:30 ` Ben Greear
2004-07-29 17:19 ` Alan Cox
2004-07-28 21:36 ` Andrew Morton
2004-07-28 21:45 ` Ben Greear
2004-07-29 4:18 ` Willy Tarreau
2004-07-30 2:20 ` Herbert Xu
2004-07-30 12:10 ` Willy Tarreau
2004-07-31 3:57 ` Herbert Xu
2004-07-31 8:33 ` Willy Tarreau
[not found] ` <200407310846.i6V8k3qq006659@uai.com.br>
2004-07-31 8:57 ` Willy Tarreau
2004-07-31 9:34 ` Jeff Garzik
2004-07-31 10:11 ` Willy Tarreau
2004-07-31 14:12 ` Matti Aarnio
2004-07-31 16:18 ` Jeff Garzik
2004-07-31 17:13 ` Ben Greear
2004-07-31 17:03 ` Ben Greear
2004-07-31 17:05 ` Willy Tarreau
2004-07-31 17:21 ` Ben Greear
2004-07-31 20:16 ` Lee Revell
2004-07-31 20:23 ` Willy Tarreau
2004-07-31 20:25 ` Alan Cox
2004-07-31 20:40 ` Lee Revell
2004-08-06 12:30 ` Willy Tarreau
2004-07-31 16:05 ` Jeff Garzik
2004-07-31 16:12 ` Willy Tarreau
2004-07-31 16:26 ` Jeff Garzik [this message]
2004-07-31 21:06 ` PATCH-2.4: MTU fix for tulip driver Willy Tarreau
2004-07-31 9:35 ` PATCH: VLAN support for 3c59x/3c90x Herbert Xu
2004-07-31 10:01 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=410BC81D.3010105@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=greearb@candelatech.com \
--cc=herbert@gondor.apana.org.au \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).