Re: [sparc32] [12/13] gcc-3.3 macro parenthesization fix for memcpy.S

Jakub Jelinek
2004-08-05T07:29:28Z

On Wed, Aug 04, 2004 at 10:01:41PM -0700, William Lee Irwin III wrote:
> On Wed, Aug 04, 2004 at 09:56:43PM -0700, William Lee Irwin III wrote:
> > SMP support is in need of a great deal of work to port it from 2.2 and
> > 2.4. Add a dependency on BROKEN in the Kconfig to warn the unwary.
>
> From: Art Haas <ahaas@airmail.net>
>
> The 1.3->1.4 changes to the arch/sparc/lib/copy_user.S file added
> parenthesis to a number of macros within that file. The BK changlog
> associated with this change indicate the change was to make the
> file work with gcc-3.3.
>
> When looking at the changes made, I see that similar macros exist in
> memcpy.S as well, so would a patch adding parens to that file be
> worthwhile? Also, just what was the problem with gcc-3.3 that was
> resolved by adding the parenthesis? Macro mis-expansion I'm guessing.

The problem was an (already fixed) gas bug, which for a short time treated
%reg - -0x02
as if there was a -- operator in between.
arch/arch/lib/memcpy.S never passes -0xNN offsets to any of these macros,
so the parenthesis is unnecessary there IMHO.

Jakub