From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752906AbbB0Keo (ORCPT ); Fri, 27 Feb 2015 05:34:44 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:54804 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbbB0Kem (ORCPT ); Fri, 27 Feb 2015 05:34:42 -0500 From: Arnd Bergmann To: Vignesh R Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Evgeniy Polyakov , Jonathan Corbet , Paul Walmsley , Tony Lindgren , Russell King , NeilBrown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] w1: masters: omap_hdq: Add support for 1-wire mode Date: Fri, 27 Feb 2015 11:34:22 +0100 Message-ID: <4111301.XAv3eRBo5S@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <54F04767.5070001@ti.com> References: <1425029057-5075-1-git-send-email-vigneshr@ti.com> <10805905.OnX7kRTk9d@wuerfel> <54F04767.5070001@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:x2emvso2d/4W8/0CxLO3doj8C4fxOUef1hWmmQzLvEpukCPpPJ8 U0irOcfwVOlcS6WZxNEDmhQd3ecSRnUu0MUYmCo5nY1ychsmfZ8JojdkaE25kwQI3ESJ/aw ZV+c2quRjGXwYW/moqllUNCu7H3d0Y3eW+I1gsidOY5vQq7tUmObzp6Er7dNrZSA9yFxEyi rKxHdTJpNOhpSJ/Li5ePA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 27 February 2015 16:01:03 Vignesh R wrote: > On Friday 27 February 2015 03:25 PM, Arnd Bergmann wrote: > > On Friday 27 February 2015 14:54:17 Vignesh R wrote: > >> +- compatible : should be "ti,omap3-1w" or "ti,am43xx-hdq" > >> > > > > Do not use wildcards in the compatible string, use real part numbers > > if you don't know the actual name of the device. > > > The DT node for hdq on AM437x is already present in mainline > (commit: 741cac5f00beb) and it declares compatibility as > "ti,am43xx-hdq". Hence, I cannot change into anything different. > No, there is no driver using this device, and the binding was not documented, so there is no problem in changing it: nobody will notice a regression when it was never working before. Arnd