Re: KVM & mouse wheel

Re: KVM & mouse wheel

[Dmitry Torokhov]

[-- Attachment #1: Type: text/plain, Size: 2019 bytes --]

Vojtech Pavlik wrote:
> On Wed, Aug 04, 2004 at 07:38:55AM -0500, Dmitry Torokhov wrote:
> > On Wednesday 04 August 2004 02:18 am, Vojtech Pavlik wrote:
> > > On Wed, Aug 04, 2004 at 12:25:19AM -0500, Dmitry Torokhov wrote:
> > >
> > > > On Tuesday 03 August 2004 11:29 pm, Marko Macek wrote:
> > > > > Jesper Juhl wrote:
> > > > >
> > > > > > <>I also had problems with my KVM switch and mouse when I
> initially
> > > > > > moved to
> > > > > > 2.6, but adding this kernel boot parameter fixed it, meybe it
> will help
> > > > > > you as well : psmouse.proto=imps
> > > > >
> > > > > This doesn't help. Only the patch I sent helps me. The problem is
> that the
> > > > > even with psmouse.proto=imps or exps, the driver still probes for
> > > > > synaptics which I
> > > > > consider a bug.
> > > > >
> > > >
> > > > No it is not - Synaptics with a track-point on a passthrough port
> will have
> > > > track-point disabled if it is not reset after probing for imps/exps.
> > >
> > > Hmm, does the imps/exps probe succeed in this case?
> >
> > No, it does not, at least not mine. It either does bare PS/2 or native,
> but
> > there are other Synaptics touchpads that can also do imps.
> 
> Ok, so how about issuing a reset when the imps probe fails? That'd take
> care of all the cases, and I suppose a Synaptics pad that can do imps
> will not be confused by it.
> 

Synaptics requires full reset, reset-disable alone is not enough.
Plus, when synaptics is detected but left in emulation mode, the
driver does synaptics-specific reset which initializes stuff that
survives reset-disable (for example it enables gestures so tapping
is guaranteed to work).

Additionally I think it's a good idea to detect hardware regardless
of the protocol it is using so user can see what he has. 

Anyway, I think that explicitely calling reset-disable after each
failed probe is a good idea... or maybe not after each probe but just
once, before probing for generic protocols (imps/exps), like in the
attached patch.

--
Dmitry



[-- Attachment #2: psmouse-probe.patch --]
[-- Type: application/octet-stream, Size: 471 bytes --]

--- linux-2.6.7/drivers/input/mouse/psmouse-base.c.orig	2004-08-04 12:30:55.985806400 -0500
+++ linux-2.6.7/drivers/input/mouse/psmouse-base.c	2004-08-04 12:34:15.392539200 -0500
@@ -461,6 +461,12 @@
 			return type;
 	}
 
+/*
+ * Reset to defaults in case the device got confused by extended
+ * protocol probes.
+ */
+	psmouse_command(psmouse, NULL, PSMOUSE_CMD_RESET_DIS);
+
 	if (max_proto >= PSMOUSE_IMEX && im_explorer_detect(psmouse)) {
 
 		if (set_properties) {

Re: KVM & mouse wheel [PATCH]

[Marko Macek]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Dmitry Torokhov wrote:

>Anyway, I think that explicitely calling reset-disable after each
>failed probe is a good idea... or maybe not after each probe but just
>once, before probing for generic protocols (imps/exps), like in the
>attached patch.
>  
>
Besides above, the attached patch moves setting the streaming mode
above setting of resolution/rate/scaling.  With that, the mouse works
fine for me in 'imex' mode without any overrides.

Mark



[-- Attachment #2: psmouse-kvm-reset-streaming.patch --]
[-- Type: text/x-patch, Size: 921 bytes --]

--- drivers/input/mouse/psmouse-base.c.orig	2004-08-04 21:02:38.045307096 +0200
+++ drivers/input/mouse/psmouse-base.c	2004-08-04 21:01:38.739322976 +0200
@@ -461,6 +461,12 @@
 			return type;
 	}
 
+/*
+ * Reset to defaults in case the device got confused by extended
+ * protocol probes.
+ */
+	psmouse_command(psmouse, NULL, PSMOUSE_CMD_RESET_DIS);
+
 	if (max_proto >= PSMOUSE_IMEX && im_explorer_detect(psmouse)) {
 
 		if (set_properties) {
@@ -581,6 +587,12 @@
 	unsigned char param[2];
 
 /*
+ * We set the mouse into streaming mode.
+ */
+
+	psmouse_command(psmouse, param, PSMOUSE_CMD_SETSTREAM);
+
+/*
  * We set the mouse report rate, resolution and scaling.
  */
 
@@ -589,12 +601,6 @@
 		psmouse_set_resolution(psmouse);
 		psmouse_command(psmouse,  NULL, PSMOUSE_CMD_SETSCALE11);
 	}
-
-/*
- * We set the mouse into streaming mode.
- */
-
-	psmouse_command(psmouse, param, PSMOUSE_CMD_SETSTREAM);
 }
 
 /*