From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Albert Cahalan <albert@users.sf.net>
Cc: Peter Williams <pwil3058@bigpond.net.au>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>,
kernel@kolivas.org, Andrew Morton OSDL <akpm@osdl.org>
Subject: Re: SCHED_BATCH and SCHED_BATCH numbering
Date: Thu, 05 Aug 2004 17:06:19 +1000 [thread overview]
Message-ID: <4111DC6B.2090902@yahoo.com.au> (raw)
In-Reply-To: <1091672930.3547.1781.camel@cube>
Albert Cahalan wrote:
> On Wed, 2004-08-04 at 23:06, Nick Piggin wrote:
>
>>Peter Williams wrote:
>>
>>
>>>Nick Piggin wrote:
>>>
>>>
>>>>However if you add or remove scheduling policies, your
>>>>p->policy method breaks.
>>>
>>>
>>>Not if Albert's numbering system is used.
>>>
>>
>>What if another realtime policy is added? Or one is removed?
>
>
> What if, what if...
>
> You're going to have to change the code anyway.
> One might toss this into <linux/sched.h> to make
> as a nice reminder:
>
> #define SCHEDS_RT (SCHED_RR|SCHED_FIFO)
>
I'm not saying your renumbering is a bad idea, but making the
argument that it would simplify rt_task is bogus.
> As it is now, SCHED_FIFO is already used as a
> bit flag in one place.
>
But it isn't a bit flag, we're just lucky it works. Submit a
patch?
next prev parent reply other threads:[~2004-08-05 7:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-04 16:50 SCHED_BATCH and SCHED_BATCH numbering Albert Cahalan
2004-08-05 1:17 ` Peter Williams
2004-08-05 1:27 ` Nick Piggin
2004-08-05 2:09 ` Peter Williams
2004-08-05 2:23 ` Nick Piggin
2004-08-05 3:03 ` Peter Williams
2004-08-05 3:06 ` Nick Piggin
2004-08-05 2:28 ` Albert Cahalan
2004-08-05 7:06 ` Nick Piggin [this message]
2004-08-05 3:36 ` Peter Williams
2004-08-05 4:15 ` Nick Piggin
2004-08-05 6:57 ` Ingo Molnar
2004-08-05 9:48 ` Albert Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4111DC6B.2090902@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=albert@users.sf.net \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pwil3058@bigpond.net.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox