Re: [PATCH 3/8] nvmem: rockchip-otp: Add clocks and reg_read to rockchip_data

Heiko Stübner
2023-05-02T08:49:23Z

Am Montag, 1. Mai 2023, 10:43:55 CEST schrieb Cristian Ciocaltea:
> In preparation to support new Rockchip OTP memory devices with different
> clock configurations and register layout, extend rockchip_data struct
> with the related members: clocks, num_clks, reg_read.
>
> Additionally, to avoid managing redundant driver data, drop num_clks
> member from rockchip_otp struct and update all references to point to
> the equivalent member in rockchip_data.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> drivers/nvmem/rockchip-otp.c | 79 ++++++++++++++++++++++--------------
> 1 file changed, 49 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c
> index 9f53bcce2f87..a5b234e60735 100644
> --- a/drivers/nvmem/rockchip-otp.c
> +++ b/drivers/nvmem/rockchip-otp.c
> @@ -54,21 +54,19 @@
>
> #define OTPC_TIMEOUT 10000
>
> +struct rockchip_data {
> + int size;
> + const char * const *clocks;
> + int num_clks;

nit: might be nice to use either "clocks" or "clks" as part for both names

other than that
Reviewed-by: Heiko Stuebner <heiko@sntech.de>