From: Markus Elfring <Markus.Elfring@web.de>
To: Wang YanQing <udknight@gmail.com>, Joe Perches <joe@perches.com>,
Andy Whitcroft <apw@canonical.com>,
kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Matteo Croce <mcroce@redhat.com>
Subject: Re: [PATCH] checkpatch: add support to check 'Fixes:' tag format
Date: Wed, 29 Apr 2020 19:40:21 +0200 [thread overview]
Message-ID: <4112ab7e-1f06-d880-e471-084c78bc84d4@web.de> (raw)
In-Reply-To: <20200429163645.GA13810@udknight>
> “...
> Do not split the tag across multiple
> lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify
> parsing scripts
> ...”
Why do you not like the reformatting of the quotation so far
(if such change descriptions should cope also with specific
Unicode characters)?
“…
Do not split the tag across multiple lines, tags are exempt from
the "wrap at 75 columns" rule in order to simplify parsing scripts.
…”
> And there is no sanity check for 'Fixes:' tag format in checkpatch the same
> as GIT_COMMIT_ID for git commit description, so let's expand the GIT_COMMIT_ID
> to add 'Fixes:' tag format check support.
I have got the impression that this wording might need another bit
of fine-tuning.
> + "Please use git commit description style '$prefix <12+ chars of sha1> (\"<$title>\")' - ie: '${init_char}" . substr($prefix, 1) . " $id (\"$description\")'\n" . $herecurr);
I imagine that the support for different quotation characters
can become helpful, can't it?
Regards,
Markus
next prev parent reply other threads:[~2020-04-29 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 16:36 [PATCH] checkpatch: add support to check 'Fixes:' tag format Wang YanQing
2020-04-29 17:40 ` Markus Elfring [this message]
2020-04-30 12:56 ` Wang YanQing
2020-04-30 14:06 ` checkpatch: Support for alternative quotation characters around commit title? Markus Elfring
2020-04-30 15:41 ` [PATCH] checkpatch: add support to check 'Fixes:' tag format Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4112ab7e-1f06-d880-e471-084c78bc84d4@web.de \
--to=markus.elfring@web.de \
--cc=alexei.starovoitov@gmail.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox