From: "" <jszhang3@mail.ustc.edu.cn>
To: stefanr@s5r6.in-berlin.de
Cc: linux-kernel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net, krh@redhat.com
Subject: [PATCH] firewire: fix some broken hardware NMI interrupt
Date: Wed, 21 May 2008 21:08:12 +0800 [thread overview]
Message-ID: <411375292.14780@ustc.edu.cn> (raw)
>From JiSheng Zhang <jszhang3@mail.ustc.edu.cn>
Some broken pci-1394 card does not clear completely on-chip memory during boot, it
may cause pci parity error, then NMI interrupt. It will emit kernel message such
as"Uhhuh. NMI received for unknown reason b1 on CPU 0. You have some hardware
problem, likely on the PCI bus. Dazed and confused, but trying to continue" etc.
If panic_on_unrecovered_nmi is set to 1, the system will panic. This patch will
fix it
--- linux-2.6.25.4/drivers/firewire/fw-ohci.c.org 2008-05-21 20:44:26.901066202
+0800
+++ linux-2.6.25.4/drivers/firewire/fw-ohci.c 2008-05-21 20:55:15.290371532 +0800
@@ -2051,6 +2051,7 @@
struct fw_ohci *ohci;
u32 bus_options, max_receive, link_speed;
u64 guid;
+ u16 reg;
int err;
size_t size;
@@ -2082,6 +2083,10 @@
pci_set_master(dev);
pci_write_config_dword(dev, OHCI1394_PCI_HCI_Control, 0);
+ /* some broken hardware */
+ pci_read_config_word(dev, PCI_COMMAND, ®);
+ reg &= ~(PCI_COMMAND_SERR | PCI_COMMAND_PARITY);
+ pci_write_config_word(dev, PCI_COMMAND, reg);
pci_set_drvdata(dev, ohci);
#if defined(CONFIG_PPC_PMAC) && defined(CONFIG_PPC32)
next reply other threads:[~2008-05-21 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 13:08 jszhang3 [this message]
2008-05-21 15:28 ` [PATCH] firewire: fix some broken hardware NMI interrupt Stefan Richter
2008-05-21 22:56 ` Stefan Richter
-- strict thread matches above, loose matches on Subject: below --
2008-05-22 12:07 JiSheng Zhang
2008-05-22 13:38 ` Stefan Richter
2008-05-22 22:45 ` Sean Bruno
2008-05-23 13:17 JiSheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=411375292.14780@ustc.edu.cn \
--to=jszhang3@mail.ustc.edu.cn \
--cc=krh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox