public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Grover <andy@groveronline.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, akpm@osdl.org
Subject: Re: [PATCH] pirq_enable_irq cleanup
Date: Sat, 07 Aug 2004 13:43:14 -0700	[thread overview]
Message-ID: <41153EE2.2060608@groveronline.com> (raw)
In-Reply-To: <1091797385.16288.24.camel@localhost.localdomain>

Alan Cox wrote:
> On Mer, 2004-08-04 at 19:14, agrover wrote:
>>This is a cleanup of pirq_enable_irq. I couldn't understand this function easily 
>>so I cleaned it up.
>>
>>- Hoisted Via quirk to top -- shouldn't break anything but who knows - can someone 
>>with this chipset test?
>>- Hoisted legacy IDE check too.
> This looks odd (its hard to read it in diff format in this case). The
> IDE check is only meant to be done if we look for an IRQ and find none.
> This tells us the device is only connected for legacy mode.

> The VIA one is fairly simple. After the IRQ has been identified or
> selected the VIA needs the "true" PCI IRQ number in the IRQ_LINE
> register because internal V-Bus devices are routed via IRQ line not via
> IRQ pin as the PCI spec says.

Thanks for the explanation.

So perhaps do you think there's any alternative ways we can make this 
function understandable? I gotta believe there's a way for it to do what 
it needs to without 5 layers of nested if()s.

Regards -- Andy


  reply	other threads:[~2004-08-07 20:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-04 18:14 [PATCH] pirq_enable_irq cleanup agrover
2004-08-06 13:03 ` Alan Cox
2004-08-07 20:43   ` Andy Grover [this message]
2004-08-07 20:45     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41153EE2.2060608@groveronline.com \
    --to=andy@groveronline.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox