From: Josh Aas <josha@sgi.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
steiner@sgi.com
Subject: Re: [PATCH] Reduce bkl usage in do_coredump
Date: Mon, 09 Aug 2004 12:45:45 -0500 [thread overview]
Message-ID: <4117B849.8090705@sgi.com> (raw)
In-Reply-To: <1092072631.6496.14553.camel@nighthawk>
> Might be nicer to just put the locking inside of format_corename() if it
> is the function itself that really needs the locking. If another use of
> it popped up, that user would get the locking for free and couldn't
> possibly forget it. Also, it's nicer to put the lock closer to the code
> that actually needs it. Untested patch to do that attached.
Probably a good idea.
> BTW, were you actually seeing a BKL contention problem, or was this just
> for cleanliness?
We have actually seen contention in do_coredump.
--
Josh Aas
Silicon Graphics, Inc. (SGI)
Linux System Software
651-683-3068
next prev parent reply other threads:[~2004-08-09 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 14:38 [PATCH] Reduce bkl usage in do_coredump Josh Aas
2004-08-09 17:30 ` Dave Hansen
2004-08-09 17:45 ` Josh Aas [this message]
2004-08-09 18:13 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4117B849.8090705@sgi.com \
--to=josha@sgi.com \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox