From: Jindrich Makovicka <makovick@kmlinux.fjfi.cvut.cz>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] HPT374 kernel panic - regression in 2.6.8
Date: Sat, 14 Aug 2004 13:14:54 +0200 [thread overview]
Message-ID: <411DF42E.5030504@kmlinux.fjfi.cvut.cz> (raw)
Hello,
HighPoint 374 driver in 2.6.8 can cause kernel panic on boot with
non-33MHz timings because some lines from an older version have been
included in the source again. After removing the check, HPT374 works
just fine using internal PLL.
--- old/hpt366.c 2004-08-14 13:06:12.000000000 +0200
+++ new/hpt366.c 2004-08-14 12:59:25.000000000 +0200
@@ -991,11 +991,6 @@
if (pci_get_drvdata(dev))
goto init_hpt37X_done;
- if (hpt_minimum_revision(dev,8))
- {
- printk(KERN_ERR "HPT374: Only 33MHz PCI timings are supported.\n");
- return -EOPNOTSUPP;
- }
/*
* adjust PLL based upon PCI clock, enable it, and wait for
* stabilization.
Regards,
--
Jindrich Makovicka
next reply other threads:[~2004-08-14 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-14 11:14 Jindrich Makovicka [this message]
2004-08-14 15:16 ` [PATCH] HPT374 kernel panic - regression in 2.6.8 Alan Cox
2004-08-16 22:30 ` Bartlomiej Zolnierkiewicz
2004-08-16 22:00 ` Alan Cox
2004-08-17 12:25 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=411DF42E.5030504@kmlinux.fjfi.cvut.cz \
--to=makovick@kmlinux.fjfi.cvut.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox