From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757751AbcAMOYj (ORCPT ); Wed, 13 Jan 2016 09:24:39 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:54655 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756194AbcAMOYh (ORCPT ); Wed, 13 Jan 2016 09:24:37 -0500 From: Arnd Bergmann To: Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: Kyungmin Park , Andrzej Hajda , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] [media] s5c73m3: remove duplicate module device table Date: Wed, 13 Jan 2016 15:23:51 +0100 Message-ID: <4126175.vzSgvM02WI@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:IK1VTpoN3Pc8GfRF0twqAQD8W3pY6EYT0r42WwRr5zN+H4ioykg NrySrq4WrAmKlFBvmIH1dZucqTm5/u7b/RTwpkGEbyfOivWOf7fjanN3WsZXZwLnUmF24zO 5bXkSqEJjOlu5306Ebgco+LHX1Q6qGu+0TaxmGZcWBDGASOJNiLhLM/WBHGR+kuWWoF6l6q C21RFP5MxgN7Rk59g6Iow== X-UI-Out-Filterresults: notjunk:1;V01:K0:UBbMLS3sP34=:q7HPylrtfCrAiO2kCutF8S IBATdoVInDY+g+inSpr9AFmDQnbyV07MG45kx2F3n6hjna+d8yGxvCODvHytuyp3Y34CMFRNT k6jsI0MUP788lvoH0UDHTKGL4mKVanDKATmOjcoMQA4E7I0MeTaH4n5pHX5VNBGBaBXedehLz R+pIsB7VD/9PVX2YYF2Wrdmz6ZBDZTYyVGvN/ufk2rztpTFk1on8iH5tvDdyup/dtzngrCx3Z YQWLD/2E0nl9/sWgDdAEZoqYJyhnW2AV0Bf+EdCAC9X5pF4S5qYM1L8hLsF6V6rm/2Cy+5X0F LK9JfVNch9WW19P2Z12uFXXWnvAS30WTjvanHyROb0c4ygFmiwwQbVBlShZqQSoGT4/zgIi3I cPJzdrnkLXFoO06LcpCviTdqSirUWl07iRfeuYWWuGVRjlbrs5vutrtlnUdvecAK7tD/jXNmm e1pdqByOuFZGpczsc5Eb+dkqrfw0XzEdXFEuq/QXLQgkccOqzndJGPT5qac/7Uu52h6lQGwXW 2nbP7ap2Vv1nAwA1Un3eoeAnEy8IWT7pbqBreS/qhP4yZ7Q4Hh0H+4WzZMsV/JB2WsuWWwiz5 NRB/mNVVtssF378WWm/YRNfF6qB0Ji9YqQaRBk6BgATil1GWW1Wq1J/mGoD8wz+ohamzI83ri bfuy4DABzQY8lyJUezqZJeVSLUGUbAwTuRTtnA3pU9prXhLmPy2iAWEpUE2O+1juf7vfe0IZG LUUnXhQvs3oCNqK7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clang complains about an extraneous definition of the module device table after the patch to add it was accidentally merged twice: ../drivers/media/i2c/s5c73m3/s5c73m3-spi.c:40:1: error: redefinition of '__mod_of__s5c73m3_spi_ids_device_table' MODULE_DEVICE_TABLE(of, s5c73m3_spi_ids); ^ ../include/linux/module.h:223:27: note: expanded from macro 'MODULE_DEVICE_TABLE' extern const typeof(name) __mod_##type##__##name##_device_table \ ^ :99:1: note: expanded from here __mod_of__s5c73m3_spi_ids_device_table This removes the second definition. Signed-off-by: Arnd Bergmann Fixes: f934a94bb566 ("[media] s5c73m3: Export OF module alias information") --- Found while doing randconfig testing with clang, this is currently only broken in linux-next, not in 4.4 diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c index 7d65b36434b1..72ef9f936e6c 100644 --- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c +++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c @@ -37,7 +37,6 @@ enum spi_direction { SPI_DIR_RX, SPI_DIR_TX }; -MODULE_DEVICE_TABLE(of, s5c73m3_spi_ids); static int spi_xmit(struct spi_device *spi_dev, void *addr, const int len, enum spi_direction dir)