From: Nathan Bryant <nbryant@optonline.net>
To: Nathan Bryant <nbryant@optonline.net>
Cc: stefandoesinger@gmx.at, acpi-devel@lists.sourceforge.net,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
"Brown, Len" <len.brown@intel.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
"Li, Shaohua" <shaohua.li@intel.com>
Subject: Re: [ACPI] [PATCH][RFC] fix ACPI IRQ routing after S3 suspend
Date: Fri, 20 Aug 2004 16:43:31 -0400 [thread overview]
Message-ID: <41266273.1010604@optonline.net> (raw)
In-Reply-To: <4126621B.3090701@optonline.net>
[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]
Oops. Forgot the patch again. See attached.
Nathan Bryant wrote:
> Stefan Dösinger wrote:
>
>> If I re-programm the IRQ to something else than IRQ10, the device
>> doesn't resume too. So it's not only a problem of IRQ 11.
>>
>>
> Seems like an anything-at-all-other-than-IRQ-10 problem. If the
> current thinking is right, your BIOS is assigning IRQ10 during boot,
> so moving it anywhere else is what causes problems.
>
> But the current thinking doesn't quite seem right, because it seeems
> like we're seeing these problems after the irqrouter is resumed. Can
> you verify that with the attached patch? The patch should give us
> enough information as long as you've got the proper kernel loglevel set.
>
> Now, I wonder if the only reason it works when you set IRQ 10 is that
> some other driver is unconditionally claiming the interrupt...
>
> Nathan
>
>> The ipw2100 driver calls pci_disable_device in it's suspend handler.
>> But I think the ipw2100 maintainers need help with suspend/resume
>> because James Ketrenos can't test it on his own system.
>>
>>
> pci_disable_device() only turns off bus-mastering, it doesn't unmap
> the I/O or disable the slot. Maybe we also need to set power state D3
> and do a device-specific disable-interrupts, but I think D0 gets
> restored for us pretty early during resume anyway...
>
> Anyway, something doesn't quite add up...
>
> Nathan
>
[-- Attachment #2: pci_linkdebug.patch --]
[-- Type: text/x-patch, Size: 396 bytes --]
===== drivers/acpi/pci_link.c 1.32 vs edited =====
--- 1.32/drivers/acpi/pci_link.c 2004-08-18 19:26:48 -04:00
+++ edited/drivers/acpi/pci_link.c 2004-08-20 16:28:40 -04:00
@@ -717,6 +717,8 @@
ACPI_FUNCTION_TRACE("irqrouter_resume");
+ printk(KERN_DEBUG "irqrouter_resume: called.\n");
+
list_for_each(node, &acpi_link.entries) {
link = list_entry(node, struct acpi_pci_link, node);
next prev parent reply other threads:[~2004-08-20 20:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-20 19:00 [ACPI] [PATCH][RFC] fix ACPI IRQ routing after S3 suspend Pallipadi, Venkatesh
2004-08-20 19:42 ` Nathan Bryant
2004-08-20 20:01 ` Stefan Dösinger
2004-08-20 20:42 ` Nathan Bryant
2004-08-20 20:43 ` Nathan Bryant [this message]
2004-08-20 20:17 ` Stefan Dösinger
-- strict thread matches above, loose matches on Subject: below --
2004-08-23 5:58 Li, Shaohua
2004-08-04 1:42 Nathan Bryant
2004-08-19 20:24 ` [ACPI] " Stefan Dösinger
2004-08-19 20:54 ` Nathan Bryant
2004-08-20 10:50 ` Stefan Dösinger
2004-08-20 12:18 ` Nathan Bryant
2004-08-20 16:36 ` Stefan Dösinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41266273.1010604@optonline.net \
--to=nbryant@optonline.net \
--cc=acpi-devel@lists.sourceforge.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=stefandoesinger@gmx.at \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox