From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Ryan Cumming <ryan@spitfire.gotdns.org>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] use hlist for pid hash
Date: Sun, 22 Aug 2004 15:26:44 +1000 [thread overview]
Message-ID: <41282E94.4020903@yahoo.com.au> (raw)
In-Reply-To: <200408212225.58536.ryan@spitfire.gotdns.org>
Ryan Cumming wrote:
> On Saturday 21 August 2004 21:46, you wrote:
>
>>This comes at the "expense" of
>>1. reintroducing the memory prefetch into the hash traversal loop;
>>2. adding new pids to the head of the list instead of the tail. I
>> suspect that if this was a big problem then the hash isn't sized
>> well or could benefit from moving hot entries to the head.
>
>
> It looks like the current code is already adding PIDs to the head: list_add()
> adds to the head of a list and list_add_tail() adds to the tail.
>
Hmm, so it is. I must have been looking at the task_list list when I
was thinking that. Well, all the better.
next prev parent reply other threads:[~2004-08-22 5:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-22 4:44 [PATCH 1/2] fix PID hash sizing Nick Piggin
2004-08-22 4:46 ` [PATCH 2/2] use hlist for pid hash Nick Piggin
2004-08-22 5:00 ` David S. Miller
2004-08-22 5:31 ` Nick Piggin
2004-08-22 5:25 ` Ryan Cumming
2004-08-22 5:26 ` Nick Piggin [this message]
2004-09-06 11:35 ` [PATCH] Allocate correct amount of memory " Anton Blanchard
2004-09-06 11:41 ` Nick Piggin
2004-08-22 12:32 ` [PATCH 1/2] fix PID hash sizing William Lee Irwin III
2004-08-23 0:16 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41282E94.4020903@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=ryan@spitfire.gotdns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox