From: Jeff Garzik <jgarzik@pobox.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: "O.Sezer" <sezeroz@ttnet.net.tr>,
linux-kernel@vger.kernel.org, davem@redhat.com
Subject: Re: [PATCH 2.4] gcc-3.4 more fixes
Date: Mon, 23 Aug 2004 18:18:23 -0400 [thread overview]
Message-ID: <412A6D2F.1030704@pobox.com> (raw)
In-Reply-To: <20040823131137.GA1779@logos.cnet>
Marcelo Tosatti wrote:
> On Mon, Aug 23, 2004 at 05:13:26PM +0300, O.Sezer wrote:
>
>>Marcelo Tosatti wrote:
>>
>>>On Mon, Aug 23, 2004 at 04:41:46PM +0300, O.Sezer wrote:
>>>
>>>
>>>>>>Ozkan,
>>>>>>
>>>>>>This are just warning fixes right?
>>>>>>
>>>>>>I dont like this patches, that is, I'm not confident about them.
>>>>>>
>>>>>>Let the warnings be.
>>>>>
>>>>>For gcc-3.4 they're warnings. For gcc-3.5 they'll cause compiler
>>>>>failures (that's what mikpe says on cset-1.1490, too)
>>>>
>>>>As a side note, almost all of them are in 2.6 anyway (can't
>>>>honestly remember which aren't)
>>>
>>>
>>>Have you nocited the deadly mistake you made I showed with the grep?
>>>
>>
>>Oopss :/ Than 2.6 has the same deadly thing. I'm too trusting I
>>guess.. The correct thing should be to change "if (!(PRIV(dev) ="
>>into "if (!(dev->phy_data =", right?
>
>
> I think so yes. A network driver expert can confirm this for us.
Not enough context is quoted for me to decipher what this refers to :(
URL?
Jeff
next prev parent reply other threads:[~2004-08-23 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-23 13:41 [PATCH 2.4] gcc-3.4 more fixes O.Sezer
2004-08-23 12:34 ` Marcelo Tosatti
2004-08-23 14:13 ` O.Sezer
2004-08-23 13:11 ` Marcelo Tosatti
2004-08-23 22:18 ` Jeff Garzik [this message]
2004-08-23 22:34 ` O.Sezer
2004-08-23 16:10 ` O.Sezer
-- strict thread matches above, loose matches on Subject: below --
2004-08-23 13:27 O.Sezer
2004-08-23 19:07 ` Jon Oberheide
2004-08-05 19:54 O.Sezer
2004-08-06 20:09 ` O.Sezer
2004-08-23 11:35 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412A6D2F.1030704@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=sezeroz@ttnet.net.tr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox