[PATCH] i8259 shutdown method for i386

[PATCH] i8259 shutdown method for i386

[Eric W. Biederman]

Greg, 
Now that you have added sys_device support to the generic
device support.  This patch to shutdown the i8259A interrupt
controller on reboot should now be safe.

Eric

diff -uNr linux-2.6.8.1/arch/i386/kernel/i8259.c linux-2.6.8.1-i8259-shutdown.i386/arch/i386/kernel/i8259.c
--- linux-2.6.8.1/arch/i386/kernel/i8259.c	Wed Aug 18 14:54:26 2004
+++ linux-2.6.8.1-i8259-shutdown.i386/arch/i386/kernel/i8259.c	Wed Aug 18 14:58:56 2004
@@ -244,9 +244,21 @@
 	return 0;
 }
 
+static int i8259A_shutdown(struct sys_device *dev)
+{
+	/* Put the i8259A into a quiescent state that
+	 * the kernel initialization code can get it
+	 * out of.
+	 */
+	outb(0xff, 0x21);	/* mask all of 8259A-1 */
+	outb(0xff, 0xA1);	/* mask all of 8259A-1 */
+	return 0;
+}
+
 static struct sysdev_class i8259_sysdev_class = {
 	set_kset_name("i8259"),
 	.resume = i8259A_resume,
+	.shutdown = i8259A_shutdown,
 };
 
 static struct sys_device device_i8259A = {

Re: [PATCH] i8259 shutdown method for i386

[Greg KH]

On Fri, Aug 20, 2004 at 02:43:06AM -0600, Eric W. Biederman wrote:
> 
> Greg, 
> Now that you have added sys_device support to the generic
> device support.  This patch to shutdown the i8259A interrupt
> controller on reboot should now be safe.

This didn't apply either.  Care to send a 2.6.9-rc1 version?

Oh, and please add the "Signed-off-by:" line.

thanks,

greg k-h

Re: [PATCH] i8259 shutdown method for i386

[Jeff Garzik]

Greg KH wrote:
> On Fri, Aug 20, 2004 at 02:43:06AM -0600, Eric W. Biederman wrote:
> 
>>Greg, 
>>Now that you have added sys_device support to the generic
>>device support.  This patch to shutdown the i8259A interrupt
>>controller on reboot should now be safe.
> 
> 
> This didn't apply either.  Care to send a 2.6.9-rc1 version?


As long as you know the kernel version it was diff'd against, you should 
be able to use BitKeeper to merge it...  just clone -rv$old_version, 
apply patch, and then pull that clone into your mainline.

	Jeff