From: Jeff Garzik <jgarzik@pobox.com>
To: bjorn.helgaas@hp.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] hp100.c: add missing pci_enable_device()
Date: Tue, 24 Aug 2004 20:41:51 -0400 [thread overview]
Message-ID: <412BE04F.3050306@pobox.com> (raw)
In-Reply-To: <200408242225.i7OMP5ak029691@hera.kernel.org>
Linux Kernel Mailing List wrote:
> diff -Nru a/drivers/net/hp100.c b/drivers/net/hp100.c
> --- a/drivers/net/hp100.c 2004-08-24 15:25:16 -07:00
> +++ b/drivers/net/hp100.c 2004-08-24 15:25:16 -07:00
> @@ -2910,10 +2910,15 @@
> int ioaddr = pci_resource_start(pdev, 0);
> u_short pci_command;
> int err;
> -
> +
> if (!dev)
> return -ENOMEM;
>
> + if (pci_enable_device(pdev)) {
_Obviously_ incomplete change. Look above, and see pci_resource_start()
Jeff
next parent reply other threads:[~2004-08-25 0:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200408242225.i7OMP5ak029691@hera.kernel.org>
2004-08-25 0:41 ` Jeff Garzik [this message]
2004-08-25 15:23 ` [PATCH] hp100.c: add missing pci_enable_device() Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412BE04F.3050306@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox