From: Jeff Garzik <jgarzik@pobox.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ibmasm: add missing pci_enable_device()
Date: Tue, 24 Aug 2004 20:43:08 -0400 [thread overview]
Message-ID: <412BE09C.4030706@pobox.com> (raw)
In-Reply-To: <200408242224.i7OMOs1H029517@hera.kernel.org>
Linux Kernel Mailing List wrote:
> diff -Nru a/drivers/misc/ibmasm/module.c b/drivers/misc/ibmasm/module.c
> --- a/drivers/misc/ibmasm/module.c 2004-08-24 15:25:05 -07:00
> +++ b/drivers/misc/ibmasm/module.c 2004-08-24 15:25:05 -07:00
> @@ -62,10 +62,17 @@
> int result = -ENOMEM;
> struct service_processor *sp;
>
> + if (pci_enable_device(pdev)) {
> + printk(KERN_ERR "%s: can't enable PCI device at %s\n",
> + DRIVER_NAME, pci_name(pdev));
> + return -ENODEV;
> + }
Another [minor] bug in this series of changes: you should propagate the
return value of pci_enable_device(), not make up your own.
Jeff
next parent reply other threads:[~2004-08-25 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200408242224.i7OMOs1H029517@hera.kernel.org>
2004-08-25 0:43 ` Jeff Garzik [this message]
2004-08-04 21:32 [PATCH] ibmasm: add missing pci_enable_device() Bjorn Helgaas
2004-08-09 17:18 ` Max Asbock
2004-08-09 17:28 ` Bjorn Helgaas
2004-08-09 22:27 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412BE09C.4030706@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox