Re: Linux 2.4.28-pre2

Re: Linux 2.4.28-pre2

[O.Sezer]

Hi Marcelo:

 > Also a bunch of gcc 3.4 fixes, hopefully we are done
 > with that now.

Fairly close, but not complete. You need the two patches at:

http://marc.theaimsgroup.com/?l=linux-kernel&m=109327862717567&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=109292095518054&w=2

(You should have them in your mailbox)

After those, there will still be five warnings which I couldn't
find an easy way to deal with:
1. the rio driver:
rio_linux.c: In function `rio_init':
rio_linux.c:1209: warning: use of cast expressions as lvalues is deprecated
rio_linux.c:1333: warning: use of cast expressions as lvalues is deprecated

2. isdn/eicon:
eicon_idi.c: In function `idi_faxdata_send':
eicon_idi.c:2057: warning: use of cast expressions as lvalues is deprecated

3. scsi/53c7,8xx.c:
53c7,8xx.c: In function `NCR53c7xx_queue_command':
53c7,8xx.c:3929: warning: use of cast expressions as lvalues is deprecated

4. rivafb:
accel.c: In function `fbcon_riva_writechr':
accel.c:157: warning: use of cast expressions as lvalues is deprecated

5. affs/super.c :
super.c: In function `parse_options':
super.c:133: warning: use of conditional expressions as lvalues is 
deprecated

As you know these are warnings in gcc3.4 but will be failures in 3.5.

Another thing is in scsi/ultrastor.c:
ultrastor.c: In function `ultrastor_queuecommand':
ultrastor.c:301: warning: matching constraint does not allow a register
ultrastor.c:301: warning: matching constraint does not allow a register

I'm no asm guy so I don't know how serious/how to fix this.

Regards,
Ozkan.

Re: Linux 2.4.28-pre2

[Adrian Bunk]

On Thu, Aug 26, 2004 at 06:26:39PM +0300, O.Sezer wrote:

> Hi Marcelo:
> 
> > Also a bunch of gcc 3.4 fixes, hopefully we are done
> > with that now.
> 
> Fairly close, but not complete. You need the two patches at:
>...

I've found six compile errors in -pre2 with gcc 3.4 I'll send patches 
for.

There are still tons of warnings for lvalues and a few other warnings, 
but I don't see a pressing need to fix these:

They are not a real problem with gcc 3.4, and whether gcc 3.5 will ever 
be supported as compiler for kernel 2.4 is a question whose answer lies 
far in the future.


> Regards,
> Ozkan.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: Linux 2.4.28-pre2

[O.Sezer]

Adrian Bunk wrote:
> On Thu, Aug 26, 2004 at 06:26:39PM +0300, O.Sezer wrote:
> 
> 
>>Hi Marcelo:
>>
>>
>>>Also a bunch of gcc 3.4 fixes, hopefully we are done
>>>with that now.
>>
>>Fairly close, but not complete. You need the two patches at:
>>...
> 
> 
> I've found six compile errors in -pre2 with gcc 3.4 I'll send patches 
> for.

Which are they, I'm curious?

> There are still tons of warnings for lvalues and a few other warnings, 

Are there more other than the two patches I referenced fix and the
five I listed? Which are they?

> but I don't see a pressing need to fix these:
> 
> They are not a real problem with gcc 3.4, and whether gcc 3.5 will ever 
> be supported as compiler for kernel 2.4 is a question whose answer lies 
> far in the future.

That is a valid point but it'd be sad if gcc3.5 wouldn't be supported.

> cu
> Adrian
> 

Cheers.
Ozkan

Re: Linux 2.4.28-pre2

[Willy Tarreau]

On Thu, Aug 26, 2004 at 10:50:03PM +0300, O.Sezer wrote:
> >They are not a real problem with gcc 3.4, and whether gcc 3.5 will ever 
> >be supported as compiler for kernel 2.4 is a question whose answer lies 
> >far in the future.
> 
> That is a valid point but it'd be sad if gcc3.5 wouldn't be supported.

Tell that to gcc developpers who constantly break compatibility between
versions. I even have userland programs which do not compile anymore with
gcc-3.3 and which I don't even know how to 'fix' (workaround ?).

Cheers,
Willy

Re: Linux 2.4.28-pre2

[Marcelo Tosatti]

On Fri, Aug 27, 2004 at 12:26:22AM +0200, Willy Tarreau wrote:
> On Thu, Aug 26, 2004 at 10:50:03PM +0300, O.Sezer wrote:
> > >They are not a real problem with gcc 3.4, and whether gcc 3.5 will ever 
> > >be supported as compiler for kernel 2.4 is a question whose answer lies 
> > >far in the future.
> > 
> > That is a valid point but it'd be sad if gcc3.5 wouldn't be supported.
> 
> Tell that to gcc developpers who constantly break compatibility between
> versions. I even have userland programs which do not compile anymore with
> gcc-3.3 and which I don't even know how to 'fix' (workaround ?).

I dont care much about having gcc 3.5 work on v2.4 right now. Right now I think 
we wont ever care about supporting it.

gcc 3.4 is more a of a concern because there is demand for it - Mikael has been
maintaining the patches out-of-the-tree for sometime now and I received
quite some reports about them (ie there is pressure for that).

But, due to the v2.4 state of life (bugfix mode only), I've been very annoyed 
by these patches already. Uninliningfunctions is the most annoying thing 
to me.

It doenst make sense for it (v2.4) to work on new-shiny-gcc next generation, v2.6/2.7 
are there to support those.

Linux 2.4.28-pre2

[Marcelo Tosatti]

Hi, 

Here goes the second -pre of v2.4.28.

It contains more SATA fixes, S390 update, number of 
PCI hotplug fixes, NFS update, IDE PCI Triflex, amongst 
others.

Also a bunch of gcc 3.4 fixes, hopefully we are done
with that now.

Enjoy


Summary of changes from v2.4.28-pre1 to v2.4.28-pre2
============================================

<achew:nvidia.com>:
  o [libata sata_nv] support for hardware, bug fixes
  o [libata sata_nv] fix leak on error

<david.martinez:rediris.es>:
  o Update ftape webpage

<linville:tuxdriver.com>:
  o Add IOI Media Bay to SCSI quirk list

<mbroemme:plusserver.de>:
  o Fix kernel oops in nsc-ircc.c

<rainer.weikusat:sncag.com>:
  o bkgoodman@bradgoodman.com: MTD cfi_cmdset_0002.c - Duplicate cleanup in error path

<sezeroz:ttnet.net.tr>:
  o pm3fb and kaweth missing casts
  o ns83820.c warning fixes
  o cpqarray/cciss gcc3.4 inline fixes
  o ieee1394/hisax gcc 3.4 inline fixes
  o radio/video gcc3.4 inline fixes
  o mtd gcc3.4 inline fixes
  o net drivers gcc3.4 inline fixes
  o scsi drivers gcc3.4 inline fixes
  o USB gcc3.4 inline fixes
  o net gcc3.4 inline fixes
  o char gcc3.4 inline fixes
  o filesystems (fs/) gcc3.4 inline fixes
  o intermezzo gcc3.4 inline fixes
  o uninline do_generic_direct_read

<thor:math.tu-berlin.de>:
  o NetMOS 9805 ParPort interface

Adrian Bunk:
  o 2.4.28-pre1: add two SATA Configure.help entries
  o disallow modular BINFMT_ELF

Alan Cox:
  o [libata] improve translation of ATA errors to SCSI sense codes
  o ad1816 sound driver web page and email address update

Andrew Morton:
  o libata build fix

Badari Pulavarty:
  o scsi PHYS_4G merging doesn't work

Bartlomiej Zolnierkiewicz:
  o Fix IDE Triflex hang on boot with two single-channel controllers

Dan Zink:
  o PCI Hotplug: fix potential hang in cpqphp

Daniel Ritz:
  o enable read prefetch on o2micro bridges to fix HDSP
  o fix EnE Cardbus bridges for HDSP

David S. Miller:
  o [SPARC64]: Add missing nop to itlb_base.S

Dely Sy:
  o PCI Hotplug: Fixes for hot-plug drivers in 2.4 kernel

Douglas Gilbert:
  o [libata] fix INQUIRY handling

Gary Hade:
  o PCI Hotplug: change MAINTAINERS

Jeff Garzik:
  o [libata] (cosmetic) sync with 2.6.x
  o [libata] support commands SYNCHRONIZE CACHE, VERIFY, VERIFY(16)
  o [libata] fix PIO data xfer on big endian
  o [libata] ATAPI PIO data xfer
  o [libata] add ioctl infrastructure
  o [libata] fix error recovery reference count and in-recovery flag
  o [ata] remove 'packed' attributed from struct ata_prd

Marcelo Tosatti:
  o Changed EXTRAVERSION to -pre2

Martin Schwidefsky:
  o s390: core changes
  o s390: ibm partition table
  o s390: system tick misaccounting
  o s390: dasd changes
  o s390: ctc fixes
  o s390: iucv net driver fixes
  o s390: qeth network driver fixes

Mikael Pettersson:
  o gcc34 inline failure fixes

Neil Brown:
  o Allow larger NFSd MAXBLKSIZE on architectures with larger PAGE_SIZE
  o Fixed possibly xdr parsing error if write size exceed 2^31
  o Use llseek instead of f_pos= for directory seeking
  o mark NFS/TCP not EXPERIMENTAL

Patrick McHardy:
  o [RBTREE]: Add rb_{first,last,prev,next}
  o [NET_SCHED]: Replace eligible list by rbtree in HFSC scheduler
  o [NET_SCHED]: Replace actlist by rbtrees in HFSC scheduler
  o [NET_SCHED]: O(1) children vtoff adjustment in HFSC scheduler
  o [PKT_SCHED]: Remove unnecessary memsets in packet schedulers

Pete Zaitcev:
  o USB: update unusual_devs.h
  o USB: remove "interrupt, status %x, frame# %i"
  o The Dell's fix for TEAC CD-210PU