public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "O.Sezer" <sezeroz@ttnet.net.tr>
To: linux-kernel@vger.kernel.org
Subject: 2.4.28-pre2 and ntfs-2.1.6b ?
Date: Thu, 26 Aug 2004 23:59:47 +0300	[thread overview]
Message-ID: <412E4F43.9030801@ttnet.net.tr> (raw)

Hi all:

With 2.4.28-pre2, ntfs-2.1.6b from linux-ntfs site
started failing to compile at aops.c:

aops.c: In function `ntfs_read_block':
aops.c:315: parse error before "else"
-- or in case of gcc3.4 --
aops.c:315: error: syntax error before "else"

This happens with gcc-3.2.2 and gcc-3.4.0
and can be fixed by:

--- aops.c.BAK	2004-08-26 19:35:11.000000000 +0300
+++ aops.c	2004-08-26 21:41:53.000000000 +0300
@@ -310,10 +310,11 @@
  		return 0;
  	}
  	/* No i/o was scheduled on any of the buffers. */
-	if (likely(!PageError(page)))
+	if (likely(!PageError(page))) {
  		SetPageUptodate(page);
-	else /* Signal synchronous i/o error. */
+	} else { /* Signal synchronous i/o error. */
  		nr = -EIO;
+	}
  	unlock_page(page);
  	return nr;
  }

The very same code used to compile fine with
2.4.27 without any changes to it. I can't see
where the problem is (it's 23:57 here ;)).
Can anyone tell, please?

Regards,
Ozkan Sezer

             reply	other threads:[~2004-08-26 21:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-26 20:59 O.Sezer [this message]
2004-08-26 22:12 ` 2.4.28-pre2 and ntfs-2.1.6b ? Willy Tarreau
2004-08-26 22:53   ` O.Sezer
2004-08-27  0:08     ` [PATCH 2.4] fix typo in mm.h introduced 2.4.28-pre2 O.Sezer
2004-08-27  9:04       ` Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=412E4F43.9030801@ttnet.net.tr \
    --to=sezeroz@ttnet.net.tr \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox