From: "O.Sezer" <sezeroz@ttnet.net.tr>
To: linux-kernel@vger.kernel.org
Cc: marcelo.tosatti@cyclades.com, willy@w.ods.org
Subject: [PATCH 2.4] fix typo in mm.h introduced 2.4.28-pre2
Date: Fri, 27 Aug 2004 03:08:47 +0300 [thread overview]
Message-ID: <412E7B8F.5050502@ttnet.net.tr> (raw)
In-Reply-To: <412E69DC.5050907@ttnet.net.tr>
[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]
> All the evidence points
> to the s390 changes in -pre2, specificly cset-1.1514 by schwidefsky
> which touches include/linux/mm.h this way:
>
> --- 1.44/include/linux/mm.h 2004-08-26 15:51:04 -07:00
> +++ 1.45/include/linux/mm.h 2004-08-26 15:51:04 -07:00
> @@ -308,11 +308,9 @@
> /* Make it prettier to test the above... */
> #define UnlockPage(page) unlock_page(page)
> #define Page_Uptodate(page) test_bit(PG_uptodate, &(page)->flags)
> -#define SetPageUptodate(page) \
> - do { \
> - arch_set_page_uptodate(page); \
> - set_bit(PG_uptodate, &(page)->flags); \
> - } while (0)
> +#ifndef SetPageUptodate
> +#define SetPageUptodate(page) set_bit(PG_uptodate, &(page)->flags);
> +#endif
> #define ClearPageUptodate(page) clear_bit(PG_uptodate, &(page)->flags)
> #define PageDirty(page) test_bit(PG_dirty, &(page)->flags)
> #define SetPageDirty(page) set_bit(PG_dirty, &(page)->flags)
>
> Marcelo, you maybe interested in this.
>
> Cheers,
> Ozkan Sezer
>
And I beleive this was a typo? Marcelo, please review and apply.
Ozkan Sezer
[-- Attachment #2: mm.h.diff --]
[-- Type: text/plain, Size: 566 bytes --]
--- 28p2/include/linux/mm.h.BAK 2004-08-27 02:39:21.000000000 +0300
+++ 28p2/include/linux/mm.h 2004-08-27 02:56:10.000000000 +0300
@@ -309,7 +309,7 @@
#define UnlockPage(page) unlock_page(page)
#define Page_Uptodate(page) test_bit(PG_uptodate, &(page)->flags)
#ifndef SetPageUptodate
-#define SetPageUptodate(page) set_bit(PG_uptodate, &(page)->flags);
+#define SetPageUptodate(page) set_bit(PG_uptodate, &(page)->flags)
#endif
#define ClearPageUptodate(page) clear_bit(PG_uptodate, &(page)->flags)
#define PageDirty(page) test_bit(PG_dirty, &(page)->flags)
next prev parent reply other threads:[~2004-08-27 0:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-26 20:59 2.4.28-pre2 and ntfs-2.1.6b ? O.Sezer
2004-08-26 22:12 ` Willy Tarreau
2004-08-26 22:53 ` O.Sezer
2004-08-27 0:08 ` O.Sezer [this message]
2004-08-27 9:04 ` [PATCH 2.4] fix typo in mm.h introduced 2.4.28-pre2 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412E7B8F.5050502@ttnet.net.tr \
--to=sezeroz@ttnet.net.tr \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox