From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755300AbdETUAl (ORCPT ); Sat, 20 May 2017 16:00:41 -0400 Received: from mout.web.de ([212.227.17.11]:57690 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbdETUAi (ORCPT ); Sat, 20 May 2017 16:00:38 -0400 To: Florian Fainelli , kernel-janitors@vger.kernel.org Cc: LKML , Wolfram Sang From: SF Markus Elfring Subject: [PATCH] vlynq: Delete an error message for a failed memory allocation in vlynq_probe() Message-ID: <412dece0-b79a-0587-9ee7-8cfd72c19a40@users.sourceforge.net> Date: Sat, 20 May 2017 22:00:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:viKo8zgC1xHYuP2CAc9WFOaO+wsGZOU9hs2s1vlTrvrMNWglxxJ QQBp6EsUnvG4vVBTwZKU8FY+eteLvPWuatPj+OsqTPjKLJB4bLRDpFXEWQCISECExir+pCw PZfipW3LbXICZ9botSHWlElMRaRBKqjFjD4jHVeG8tLuOz4U4cBbhBmoX6K8yZvazIILcuW Ym9mkDa5VE4dusfJxi2RA== X-UI-Out-Filterresults: notjunk:1;V01:K0:s1gQM64IMOY=:X8+11PfD/2NL+J/dsMXmt1 XX39M5OdCcjXOjmUKcbhlwYs1Xa1C1tpCPo6qp+I0aiW6KrTUXOZIMpOD/rO2Z3V6ZxFK6B1m /vIDZZd+qL2G1kEqjMskgFOnhI0gamaR6+u8DObsMTjyXMaomsJgiQOeBme5DlsAVYDomQIEH UimyUguk6xWtt+bHj2/ZLGVTgmeDdjqd5MfTJdi+z62k/f/RuTtP/00GXHCtHnexFfV8zCKp6 qAHzUOR0hAs3eO5kjyK4sXbnoNYe4h3UT9J9ji1qUIWireaLh5N36Wc+xyyVv/5rcPXa/BIKZ drTXqgfR638+nxr1Wwf6jh2g7AZK8JQ2y9e2KvhoxkvxOMpIRMe2HOfkfhJQwDoAbS90a1aZs hAGti9rbXhhNocvAGq7VvQ37CX2AwTYWOv5VPECWZi9tzgqy7ZSJh+wxXkIqDGs8c/7SCHeHI IpQBbtoJjjkYIlV+ZNr3IR3z1K0EVfIr9dOsLxlQ+5kB2F5lQTBGwoNXNDuRRvRq8079BNmN0 YVaAAVmbkWqylE+Q2UXDcrt8rfei2Zxd2NaOO1VUzwHEEu+vWpJ73Mtdh6+aftQE4OPXCMzK3 raeEnE5KsSLfk7HJ11YSeV9mEtJaXnxJfA1JmVD4woLLQtrjlPxiLHLgF0ksK2/6DwzpS/SS4 mlIeyLmoRJZuD2u84YCIOOlw1fg8U895U3/vn2q/pP+WIc3GcTVm1m9DiV6JwPifl5rRjpoF4 /bad+hR9gGZy/IRTifZEpnIh9ELF9IRLxpVHiQ5HP9OU+pGKDsgk9yCpnNdtzTdd8jLLzOqZk LyMzS4B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 20 May 2017 21:53:55 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/vlynq/vlynq.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c index c0227f9418eb..08173463e7eb 100644 --- a/drivers/vlynq/vlynq.c +++ b/drivers/vlynq/vlynq.c @@ -684,11 +684,8 @@ static int vlynq_probe(struct platform_device *pdev) return -ENODEV; dev = kzalloc(sizeof(*dev), GFP_KERNEL); - if (!dev) { - printk(KERN_ERR - "vlynq: failed to allocate device structure\n"); + if (!dev) return -ENOMEM; - } dev->id = pdev->id; dev->dev.bus = &vlynq_bus_type; -- 2.13.0