Re: [PATCH v1 4/6] dt-bindings: power: rockchip: add regulator support

Heiko Stübner
2024-09-10T18:50:26Z

Am Dienstag, 10. September 2024, 19:57:13 CEST schrieb Sebastian Reichel:
> Add optional support for a voltage supply required to enable a
> power domain. The binding follows the way it is handled by the
> Mediatek binding to keep things consistent.
>
> This will initially be used by the RK3588 GPU power domain, which
> fails to be enabled when the GPU regulator is not enabled.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

That we have regulators supplying internal components in the soc
is the case for all Rockchip SoCs, though it looks like thankfully this
hadn't bitten us before.

So having the ability to define those supplies makes a lot of sense

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
> .../devicetree/bindings/power/rockchip,power-controller.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> index 0d5e999a58f1..0b4c5b174812 100644
> --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -131,6 +131,9 @@ $defs:
> A number of phandles to clocks that need to be enabled
> while power domain switches state.
>
> + domain-supply:
> + description: domain regulator supply.
> +
> pm_qos:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> items:
>