From: Jeff Garzik <jgarzik@pobox.com>
To: James.Bottomley@SteelEye.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Add x86 implementation of dma_declare_coherent_memory
Date: Sun, 29 Aug 2004 03:30:10 -0400 [thread overview]
Message-ID: <41318602.3060900@pobox.com> (raw)
In-Reply-To: <200408290606.i7T66G08009639@hera.kernel.org>
Linux Kernel Mailing List wrote:
> +void dma_release_declared_memory(struct device *dev)
> +{
> + struct dma_coherent_mem *mem = dev->dma_mem;
> +
> + if(!mem)
> + return;
> + dev->dma_mem = NULL;
> + kfree(mem->bitmap);
> + kfree(mem);
> +}
> +EXPORT_SYMBOL(dma_release_declared_memory);
There seems to be an iounmap() call missing.
Or is it me who is missing something? :)
Jeff
parent reply other threads:[~2004-08-29 7:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200408290606.i7T66G08009639@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41318602.3060900@pobox.com \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox