From: Neil Horman <nhorman@redhat.com>
To: "Marc Strämke" <marcstraemke.work@gmx.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Problem accessing Sandisk CompactFlash Cards (Connected to the IDE bus)
Date: Mon, 30 Aug 2004 10:23:53 -0400 [thread overview]
Message-ID: <41333879.2040902@redhat.com> (raw)
In-Reply-To: <cguj7n$gur$1@sea.gmane.org>
Marc Strämke wrote:
> Marcelo Tosatti wrote:
>
>> Indeed this is a typo but has been fixed on 2.4.26:
>>
>> if (drive->removable && id != NULL) {
>
> It never gets past this check because drive->removable is not set!
Theres actually a more interesting difference to notice:
In the working dmesg output I see this:
> hda: SanDisk SDCFB-128, CFA DISK drive
While in the non working dmesg output we have:
> hdb: SanDisk SDCFB-128, ATA DISK drive
Tracing back through the code it looks to me like we get the ATA disk
print in the event that this test in do_identify:
/*
* Check for an ATAPI device
*/
if (cmd == WIN_PIDENTIFY) {
that would explain why the drive_is_flashcard test is getting skipped,
why setting removable is making no difference, and why your card is
being identified as an ATA device. It looks as though the WIN_PIDENTIFY
command is sent down to this routine from ide_probe_for_drive in this
snip of code:
/* if !(success||timed-out) */
if (do_probe(drive, WIN_IDENTIFY) >= 2) {
/* look for ATAPI device */
(void) do_probe(drive, WIN_PIDENTIFY);
}
So it would seem that WIN_PIDENTIFY is issued only if a WIN_IDENTIFY
command fails with an rc greater than 2. I would suggest instrumenting
this area of the code to see what the WIN_IDENTIFY command is returning
on the working and non-working systems. I'm betting you will find a
difference, and we'll be able to track down the problem from there.
HTH
Neil
--
/***************************************************
*Neil Horman
*Software Engineer
*Red Hat, Inc.
*nhorman@redhat.com
*gpg keyid: 1024D / 0x92A74FA1
*http://pgp.mit.edu
***************************************************/
next prev parent reply other threads:[~2004-08-30 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-29 8:01 Problem accessing Sandisk CompactFlash Cards (Connected to the IDE bus) Marc Strämke
2004-08-29 13:38 ` Neil Horman
2004-08-29 16:06 ` Marc Strämke
2004-08-30 0:08 ` Neil Horman
2004-08-30 1:07 ` Marcelo Tosatti
2004-08-30 7:01 ` Marc Strämke
2004-08-30 14:23 ` Neil Horman [this message]
2004-08-30 15:49 ` Marc Strämke
2004-08-30 15:23 ` Alan Cox
2004-08-30 17:10 ` Neil Horman
2004-08-30 17:31 ` Marc Strämke
2004-08-30 13:04 ` Alan Cox
2004-08-30 7:12 ` Meelis Roos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41333879.2040902@redhat.com \
--to=nhorman@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcstraemke.work@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox