From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: ye.xingchen@zte.com.cn, s.shtylyov@omp.ru
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
chi.minghao@zte.com.cn
Subject: Re: [PATCH] ata: ep93xx: use devm_platform_get_and_ioremap_resource()
Date: Sat, 12 Nov 2022 11:11:59 +0900 [thread overview]
Message-ID: <413631cb-b9fa-b148-9dc7-ccca6047ace4@opensource.wdc.com> (raw)
In-Reply-To: <202211111647123266703@zte.com.cn>
On 11/11/22 17:47, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/ata/pata_ep93xx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
> index 6c75a22db12b..47845d920075 100644
> --- a/drivers/ata/pata_ep93xx.c
> +++ b/drivers/ata/pata_ep93xx.c
> @@ -931,8 +931,7 @@ static int ep93xx_pata_probe(struct platform_device *pdev)
> goto err_rel_gpio;
> }
>
> - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ide_base = devm_ioremap_resource(&pdev->dev, mem_res);
> + ide_base = devm_platform_get_and_ioremap_resource(pdev, 0, &mem_res);
> if (IS_ERR(ide_base)) {
> err = PTR_ERR(ide_base);
> goto err_rel_gpio;
Applied to for-6.2 with the title chaged to "ata: pata_ep93xx: use...".
Thanks !
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2022-11-12 2:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 8:47 [PATCH] ata: ep93xx: use devm_platform_get_and_ioremap_resource() ye.xingchen
2022-11-11 12:30 ` Sergey Shtylyov
2022-11-12 2:11 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413631cb-b9fa-b148-9dc7-ccca6047ace4@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=chi.minghao@zte.com.cn \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox