* Problem with cdrom-range-fixes-patch in 2.6.9-rc1-mm2
@ 2004-09-02 14:08 Grant Wilson
2004-09-03 6:42 ` Andy Polyakov
0 siblings, 1 reply; 2+ messages in thread
From: Grant Wilson @ 2004-09-02 14:08 UTC (permalink / raw)
To: appro; +Cc: Linux Kernel Mailing List
Hi,
With this patch applied a CDROMVOLREAD ioctl returns EINVAL. I believe
that this is because of an error in the 'sanity check' added by the patch:
if ((buffer[offset] & 0x3f) == GPMODE_AUDIO_CTL_PAGE ||
^^
should be !=
Yours,
Grant Wilson
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Problem with cdrom-range-fixes-patch in 2.6.9-rc1-mm2
2004-09-02 14:08 Problem with cdrom-range-fixes-patch in 2.6.9-rc1-mm2 Grant Wilson
@ 2004-09-03 6:42 ` Andy Polyakov
0 siblings, 0 replies; 2+ messages in thread
From: Andy Polyakov @ 2004-09-03 6:42 UTC (permalink / raw)
To: Grant Wilson; +Cc: Linux Kernel Mailing List
Grant Wilson wrote:
> Hi,
> With this patch applied a CDROMVOLREAD ioctl returns EINVAL. I believe
> that this is because of an error in the 'sanity check' added by the patch:
>
> if ((buffer[offset] & 0x3f) == GPMODE_AUDIO_CTL_PAGE ||
> ^^
> should be !=
Yes, absolutely. It should be != GPMODE_AUDIO_CTL_PAGE. Thanks! A.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-03 6:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-02 14:08 Problem with cdrom-range-fixes-patch in 2.6.9-rc1-mm2 Grant Wilson
2004-09-03 6:42 ` Andy Polyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox