From: Kirill Korotaev <dev@sw.ru>
To: Dmitry Torokhov <dtor_core@ameritech.net>,
torvalds@osdl.org, wli@holomorphy.com,
linux-kernel@vger.kernel.org
Subject: Re: INIT hangs with tonight BK pull (2.6.9-rc1+)
Date: Fri, 03 Sep 2004 12:00:57 +0400 [thread overview]
Message-ID: <413824B9.8080600@sw.ru> (raw)
In-Reply-To: <200409030204.11806.dtor_core@ameritech.net>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
> After doing BK pull last night INIT gets stuck in do_tty_hangup after
> executing rc.sysinit. Was booting fine with pull from 2 days ago...
>
> Anyone else seeing this?
>
> I suspect pidhash patch because it touched tty_io.c, but I have not tried
> reverting it as it is getting too late here... So I apologize in advance
> if I am pointing finger at the innocent ;)
Oops, you are right. These do_each_task_pid()/while_each_task_pid() do
loop 4ever with 'continue' inside.
Strange, that I haven't faced the problem on my machine before sending
the patch... :(
Sorry for the inconvinience. Patch is inside.
Kirill
[-- Attachment #2: diff-pid-sent2-fix --]
[-- Type: text/plain, Size: 662 bytes --]
--- ./include/linux/pid.h.pid2 2004-09-03 11:52:27.510664040 +0400
+++ ./include/linux/pid.h 2004-09-03 11:40:33.616192496 +0400
@@ -46,10 +46,10 @@ extern void switch_exec_pids(struct task
do {
#define while_each_task_pid(who, type, task) \
- task = pid_task((task)->pids[type].pid_list.next,\
- type); \
- prefetch((task)->pids[type].pid_list.next); \
- } while (hlist_unhashed(&(task)->pids[type].pid_chain));\
+ } while (task = pid_task((task)->pids[type].pid_list.next,\
+ type), \
+ prefetch((task)->pids[type].pid_list.next), \
+ hlist_unhashed(&(task)->pids[type].pid_chain)); \
} \
#endif /* _LINUX_PID_H */
next prev parent reply other threads:[~2004-09-03 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 7:04 INIT hangs with tonight BK pull (2.6.9-rc1+) Dmitry Torokhov
2004-09-03 7:32 ` William Lee Irwin III
2004-09-03 8:09 ` Kirill Korotaev
2004-09-03 8:06 ` William Lee Irwin III
2004-09-03 8:00 ` Kirill Korotaev [this message]
2004-09-04 6:06 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413824B9.8080600@sw.ru \
--to=dev@sw.ru \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox