From: Martin Wilck <martin.wilck@fujitsu-siemens.com>
To: William Lee Irwin III <wli@holomorphy.com>, linux-kernel@vger.kernel.org
Subject: Re: [1/4] standardize bit waiting data type
Date: Fri, 03 Sep 2004 11:53:55 +0200 [thread overview]
Message-ID: <41383F33.4050503@fujitsu-siemens.com> (raw)
In-Reply-To: <2y7Hd-1aP-21@gated-at.bofh.it>
William Lee Irwin III wrote:
> @@ -153,15 +119,13 @@
> void __wait_on_buffer(struct buffer_head * bh)
> {
> wait_queue_head_t *wqh = bh_waitq_head(bh);
> - DEFINE_BH_WAIT(wait, bh);
> + DEFINE_WAIT_BIT(wait, &bh->b_state, BH_Lock);
>
> - do {
> - prepare_to_wait(wqh, &wait.wait, TASK_UNINTERRUPTIBLE);
> - if (buffer_locked(bh)) {
> - sync_buffer(bh);
> - io_schedule();
> - }
> - } while (buffer_locked(bh));
> + prepare_to_wait(wqh, &wait.wait, TASK_UNINTERRUPTIBLE);
> + if (buffer_locked(bh)) {
> + sync_buffer(bh);
> + io_schedule();
> + }
> finish_wait(wqh, &wait.wait);
> }
Why don't you need a do..while loop any more ?
There is also no loop in __wait_on_bit() in the completed patch series.
Cheers
Martin
next parent reply other threads:[~2004-09-03 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2xoKb-2Pa-27@gated-at.bofh.it>
[not found] ` <2y3X5-73V-37@gated-at.bofh.it>
[not found] ` <2y46A-798-17@gated-at.bofh.it>
[not found] ` <2y4T1-7GM-17@gated-at.bofh.it>
[not found] ` <2y52E-7Li-11@gated-at.bofh.it>
[not found] ` <2y5ci-7Qz-7@gated-at.bofh.it>
[not found] ` <2y5m3-7VH-5@gated-at.bofh.it>
[not found] ` <2y7Hd-1aP-21@gated-at.bofh.it>
2004-09-03 9:53 ` Martin Wilck [this message]
2004-09-03 9:42 ` [1/4] standardize bit waiting data type William Lee Irwin III
2004-09-03 9:55 ` William Lee Irwin III
2004-08-26 8:47 2.6.9-rc1-mm1 Andrew Morton
2004-08-28 5:26 ` [0/4] standardized waitqueue hashing William Lee Irwin III
2004-08-28 5:31 ` [1/4] standardize bit waiting data type William Lee Irwin III
2004-08-28 6:17 ` Andrew Morton
2004-08-28 6:34 ` William Lee Irwin III
2004-08-28 6:40 ` Andrew Morton
2004-08-28 6:48 ` William Lee Irwin III
2004-08-28 9:20 ` William Lee Irwin III
2004-08-28 9:18 ` Christoph Hellwig
2004-08-28 9:20 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41383F33.4050503@fujitsu-siemens.com \
--to=martin.wilck@fujitsu-siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox