[PATCH] [ppc64] cleanup asm/processor.h

[PATCH] [ppc64] cleanup asm/processor.h

[Anton Blanchard]

Wrap a lot more of processor.h in #ifdef __KERNEL__ / __ASSEMBLY__.
Remove now unised EXC_FRAME_SIZE.

Signed-off-by: Anton Blanchard <anton@samba.org>

===== processor.h 1.51 vs edited =====
--- 1.51/include/asm-ppc64/processor.h	Tue Aug 24 19:08:17 2004
+++ edited/processor.h	Thu Sep  2 22:12:39 2004
@@ -20,12 +20,6 @@
 #include <asm/ptrace.h>
 #include <asm/types.h>
 
-/*
- * Default implementation of macro that returns current
- * instruction pointer ("program counter").
- */
-#define current_text_addr() ({ __label__ _l; _l: &&_l;})
-
 /* Machine State Register (MSR) Fields */
 #define MSR_SF_LG	63              /* Enable 64 bit mode */
 #define MSR_ISF_LG	61              /* Interrupt 64b mode valid on 630 */
@@ -410,6 +404,12 @@
 #define XGLUE(a,b) a##b
 #define GLUE(a,b) XGLUE(a,b)
 
+/* iSeries CTRL register (for runlatch) */
+
+#define CTRLT		0x098
+#define CTRLF		0x088
+#define RUNLATCH	0x0001
+
 #ifdef __ASSEMBLY__
 
 #define _GLOBAL(name) \
@@ -438,8 +438,13 @@
 	.type GLUE(.,name),@function; \
 GLUE(.,name):
 
-#endif /* __ASSEMBLY__ */
+#else /* __ASSEMBLY__ */
 
+/*
+ * Default implementation of macro that returns current
+ * instruction pointer ("program counter").
+ */
+#define current_text_addr() ({ __label__ _l; _l: &&_l;})
 
 /* Macros for setting and retrieving special purpose registers */
 
@@ -461,20 +466,9 @@
 #define mttbl(v)	asm volatile("mttbl %0":: "r"(v))
 #define mttbu(v)	asm volatile("mttbu %0":: "r"(v))
 
-/* iSeries CTRL register (for runlatch) */
-
-#define CTRLT		0x098
-#define CTRLF		0x088
-#define RUNLATCH	0x0001
-
-/* Size of an exception stack frame contained in the paca. */
-#define EXC_FRAME_SIZE 64
-
 #define mfasr()		({unsigned long rval; \
 			asm volatile("mfasr %0" : "=r" (rval)); rval;})
 
-#ifndef __ASSEMBLY__
-
 static inline void set_tb(unsigned int upper, unsigned int lower)
 {
 	mttbl(0);
@@ -485,6 +479,8 @@
 #define __get_SP()	({unsigned long sp; \
 			asm volatile("mr %0,1": "=r" (sp)); sp;})
 
+#ifdef __KERNEL__
+
 extern int have_of;
 
 struct task_struct;
@@ -507,8 +503,6 @@
 extern struct task_struct *last_task_used_math;
 extern struct task_struct *last_task_used_altivec;
 
-
-#ifdef __KERNEL__
 /* 64-bit user address space is 41-bits (2TBs user VM) */
 #define TASK_SIZE_USER64 (0x0000020000000000UL)
 
@@ -520,8 +514,6 @@
 
 #define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \
 		TASK_SIZE_USER32 : TASK_SIZE_USER64)
-#endif /* __KERNEL__ */
-
 
 /* This decides where the kernel will search for a free chunk of vm
  * space during mmap's.
@@ -626,9 +618,11 @@
 
 #define spin_lock_prefetch(x)	prefetchw(x)
 
-#endif /* ASSEMBLY */
-
 #define HAVE_ARCH_PICK_MMAP_LAYOUT
+
+#endif /* __KERNEL__ */
+
+#endif /* __ASSEMBLY__ */
 
 /*
  * Number of entries in the SLB. If this ever changes we should handle

[PATCH] [ppc64] Allow SD_NODES_PER_DOMAIN to be overridden

[Anton Blanchard]

Allow SD_NODES_PER_DOMAIN to be overridden.
On ppc64 set this at 16 so our top level scheduling domains will
include all nodes.

Signed-off-by: Anton Blanchard <anton@samba.org>

diff -puN include/asm-ppc64/processor.h~fix_smt include/asm-ppc64/processor.h
--- foobar2/include/asm-ppc64/processor.h~fix_smt	2004-09-02 22:22:49.861931162 +1000
+++ foobar2-anton/include/asm-ppc64/processor.h	2004-09-02 22:27:15.829370041 +1000
@@ -620,6 +620,8 @@ static inline void prefetchw(const void 
 
 #define HAVE_ARCH_PICK_MMAP_LAYOUT
 
+#define SD_NODES_PER_DOMAIN 16
+
 #endif /* __KERNEL__ */
 
 #endif /* ASSEMBLY */
diff -puN kernel/sched.c~fix_smt kernel/sched.c
--- foobar2/kernel/sched.c~fix_smt	2004-09-02 22:28:29.144791718 +1000
+++ foobar2-anton/kernel/sched.c	2004-09-02 22:28:32.859032577 +1000
@@ -4305,7 +4305,9 @@ __init static int cpu_to_phys_group(int 
 #ifdef CONFIG_NUMA
 
 /* Number of nearby nodes in a node's scheduling domain */
+#ifndef SD_NODES_PER_DOMAIN
 #define SD_NODES_PER_DOMAIN 4
+#endif
 
 static DEFINE_PER_CPU(struct sched_domain, node_domains);
 static struct sched_group sched_group_nodes[MAX_NUMNODES];
_

Re: [PATCH] [ppc64] Allow SD_NODES_PER_DOMAIN to be overridden

[Nick Piggin]

Jesse Barnes wrote:

>
>Yep, if I add the arch define the domains are built correctly.  Though I'm 
>getting a warning:
>
>...
>ERROR groups don't span domain->span
>CPU31:  online
>...
>
>

Hmm, this might be a problem. I don't think it can have been different 
before
this patch though... Can you send the full output privately? Thanks.


>Here's the updated patch.
>
>Jesse (note, no 'i')
>
>

Sorry - I think it is one of those letter sequences that is hard-wired
in my brain :\