From: Kirill Korotaev <dev@sw.ru>
To: linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org
Subject: Q: bugs in generic_forget_inode()?
Date: Mon, 06 Sep 2004 16:06:58 +0400 [thread overview]
Message-ID: <413C52E2.10809@sw.ru> (raw)
Hello,
1. I found that generic_forget_inode() calls write_inode_now() dropping
inode_lock and destroys inode after that. The problem is that
write_inode_now() can sleep and during this sleep someone can find inode
in the hash, w/o I_FREEING state and with i_count = 0.
If such inode will be iget'ed, then it will be iput'ed once more later
messing with the current iput(). So the inode can be cleared and
destroyed twice.
2. Why there is no wake_up_inode() in generic_forget_inode() like in
generic_delete_inode()? Looks like it is missing...
is it bugs in generic_forget_inode()?
Kirill
next reply other threads:[~2004-09-06 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-06 12:06 Kirill Korotaev [this message]
2004-09-06 19:35 ` Q: bugs in generic_forget_inode()? Andrew Morton
2004-09-10 9:04 ` Kirill Korotaev
2004-09-10 9:11 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413C52E2.10809@sw.ru \
--to=dev@sw.ru \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox