[PATCH v2] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1

[PATCH v2] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1

[Bhavya Kapoor]

mmc1 is not functional and needs clock loopback so that it can
create sampling clock from this for high speed SDIO operations.
Thus, add clklb pin mux to get mmc1 working.

Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
---

changelog v1->v2 : 
- updated the commit message for better explanation

link to v1 : https://lore.kernel.org/all/20240807101624.2713490-1-b-kapoor@ti.com/

Rebased to next-20240809

 arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
index 90dbe31c5b81..d5ceab79536c 100644
--- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
@@ -204,6 +204,7 @@ main_mmc1_pins_default: main-mmc1-default-pins {
 		pinctrl-single,pins = <
 			J721S2_IOPAD(0x104, PIN_INPUT, 0) /* (P23) MMC1_CLK */
 			J721S2_IOPAD(0x108, PIN_INPUT, 0) /* (N24) MMC1_CMD */
+			J721S2_IOPAD(0x100, PIN_INPUT, 0) /* (###) MMC1_CLKLB */
 			J721S2_IOPAD(0x0fc, PIN_INPUT, 0) /* (M23) MMC1_DAT0 */
 			J721S2_IOPAD(0x0f8, PIN_INPUT, 0) /* (P24) MMC1_DAT1 */
 			J721S2_IOPAD(0x0f4, PIN_INPUT, 0) /* (R24) MMC1_DAT2 */
-- 
2.34.1

Re: [PATCH v2] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1

[Manorit Chawdhry]

Hi Bhavya,

On 12:52-20240809, Bhavya Kapoor wrote:
> mmc1 is not functional and needs clock loopback so that it can
> create sampling clock from this for high speed SDIO operations.
> Thus, add clklb pin mux to get mmc1 working.
> 
> Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
> ---
> 

R-by already given in v1 [0]

[0]: https://lore.kernel.org/all/20240808050914.4jleprwmlrtv4alb@uda0497581/

Regards,
Manorit

Re: [PATCH v2] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1

[Bhavya Kapoor]

HI Manorit, please review again for the limitation you found in the v1.

Thanks and Regards

On 12/08/24 10:40, Manorit Chawdhry wrote:
> Hi Bhavya,
>
> On 12:52-20240809, Bhavya Kapoor wrote:
>> mmc1 is not functional and needs clock loopback so that it can
>> create sampling clock from this for high speed SDIO operations.
>> Thus, add clklb pin mux to get mmc1 working.
>>
>> Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>> Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
>> ---
>>
> R-by already given in v1 [0]
>
> [0]: https://lore.kernel.org/all/20240808050914.4jleprwmlrtv4alb@uda0497581/
>
> Regards,
> Manorit

Re: [PATCH v2] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1

[Manorit Chawdhry]

Hi Bhavya,

On 12:23-20240812, Bhavya Kapoor wrote:
> HI Manorit, please review again for the limitation you found in the v1.

What I meant is that my R-by stands but I can understand the confusion..

> 
> Thanks and Regards
> 
> On 12/08/24 10:40, Manorit Chawdhry wrote:
> > Hi Bhavya,
> > 
> > On 12:52-20240809, Bhavya Kapoor wrote:
> > > mmc1 is not functional and needs clock loopback so that it can
> > > create sampling clock from this for high speed SDIO operations.
> > > Thus, add clklb pin mux to get mmc1 working.
> > > 
> > > Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
> > > Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> > > Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
> > > ---
> > > 
> > R-by already given in v1 [0]
> > 
> > [0]: https://lore.kernel.org/all/20240808050914.4jleprwmlrtv4alb@uda0497581/
>

Reviewed-by: Manorit Chawdhry <m-chawdhry@ti.com>

Regards,
Manorit

 > 
> > Regards,
> > Manorit

Re: [PATCH v2] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1

[Nishanth Menon]

Hi Bhavya Kapoor,

On Fri, 09 Aug 2024 12:52:31 +0530, Bhavya Kapoor wrote:
> mmc1 is not functional and needs clock loopback so that it can
> create sampling clock from this for high speed SDIO operations.
> Thus, add clklb pin mux to get mmc1 working.
> 
> 

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1
      commit: f2a5177bb83dce16f13c9f5f8f828714e4788a8d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D