From: Nathan Bryant <nbryant@optonline.net>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: john.ronciak@intel.com, ganesh.venkatesan@intel.com,
scott.feldman@intel.com, Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix for spurious interrupts on e100 resume
Date: Thu, 09 Sep 2004 19:57:17 -0400 [thread overview]
Message-ID: <4140EDDD.8010808@optonline.net> (raw)
In-Reply-To: <1094769368.4298.7.camel@localhost>
Jeremy Fitzhardinge wrote:
> static void e100_hw_reset(struct nic *nic)
> {
>+ /* Mask off our interrupt line - it's unmasked after reset
>+ Do it early to prevent spurious interrupts. */
>+ e100_disable_irq(nic);
>+
> /* Put CU and RU into idle with a selective reset to get
> * device off of PCI bus */
> writel(selective_reset, &nic->csr->port);
>@@ -605,9 +609,6 @@ static void e100_hw_reset(struct nic *ni
> writeb(cuc_load_base, &nic->csr->scb.cmd_lo);
> mdelay(20);
> }
>-
>- /* Mask off our interrupt line - it's unmasked after reset */
>- e100_disable_irq(nic);
> }
>
> static int e100_self_test(struct nic *nic)
>
You sure this is right? The comment seems to imply that writing the
reset command to the registers also clears the interrupt mask. So you
might need to have the e100_disable_irq() both before and after the reset.
next prev parent reply other threads:[~2004-09-09 23:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-09 22:36 [PATCH] Fix for spurious interrupts on e100 resume Jeremy Fitzhardinge
2004-09-09 23:57 ` Nathan Bryant [this message]
2004-09-10 0:53 ` Jeremy Fitzhardinge
2004-09-13 22:53 ` Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2004-09-30 16:26 Venkatesan, Ganesh
2004-09-30 19:01 ` Jeremy Fitzhardinge
2004-09-30 19:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4140EDDD.8010808@optonline.net \
--to=nbryant@optonline.net \
--cc=akpm@osdl.org \
--cc=ganesh.venkatesan@intel.com \
--cc=jeremy@goop.org \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox