From: Eric Valette <eric.valette@free.fr>
To: Greg KH <greg@kroah.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, petkan@nucleusys.com
Subject: Re: 2.6.9-rc1-mm4 badness in rtl8150.c ethernet driver : fixed
Date: Fri, 10 Sep 2004 08:45:07 +0200 [thread overview]
Message-ID: <41414D73.5080902@free.fr> (raw)
In-Reply-To: <20040909223605.GA17655@kroah.com>
Greg KH wrote:
> On Thu, Sep 09, 2004 at 03:24:54PM -0700, Andrew Morton wrote:
>
>>Eric Valette <eric.valette@free.fr> wrote:
>>
>>>Here is a small patch that makes the card functionnal again. I've
>>>forwarded the patch to driver author also.
>>>
>>>--- linux/drivers/usb/net/rtl8150.c-2.6.9-rc1-mm4.orig 2004-09-09 11:15:11.000000000 +0200
>>>+++ linux/drivers/usb/net/rtl8150.c 2004-09-09 11:15:46.000000000 +0200
>>>@@ -341,7 +341,7 @@
>>>
>>> static int rtl8150_reset(rtl8150_t * dev)
>>> {
>>>- u8 data = 0x11;
>>>+ u8 data = 0x10;
>>
>>hm, OK. Presumably the change (which comes in via the bk-usb tree) was
>>made for a reason. So I suspect both versions are wrong ;)
>>
>>But it might be risky for Greg to merge this patch up at present.
>
>
> As all your patch does is revert the patch in my tree (it was a one line
> change), mainline should work just fine for you, right?
>
> I'll defer to Petkan as to what to do about this, as he sent me that
> patch for a good reason I imagine :)
FYI : I already forwarded the patch to the author. Just copied LKML so
that other can get the fix easily.
NB : I just reverted one small change, the rest of the changes (mainly
access to driver private data, and IOCTL ops) are OK...
--
__
/ ` Eric Valette
/-- __ o _. 6 rue Paul Le Flem
(___, / (_(_(__ 35740 Pace
Tel: +33 (0)2 99 85 26 76 Fax: +33 (0)2 99 85 26 76
E-mail: eric.valette@free.fr
next prev parent reply other threads:[~2004-09-10 6:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 13:24 2.6.9-rc1-mm4 badness in rtl8150.c ethernet driver Eric Valette
2004-09-07 13:30 ` Eric Valette
2004-09-09 9:42 ` 2.6.9-rc1-mm4 badness in rtl8150.c ethernet driver : fixed Eric Valette
2004-09-09 22:24 ` Andrew Morton
2004-09-09 22:36 ` Greg KH
2004-09-10 6:45 ` Eric Valette [this message]
2004-09-10 9:34 ` Petko Manolov
2004-09-10 11:05 ` Eric Valette
2004-09-10 11:54 ` Petko Manolov
2004-09-11 17:29 ` rtl8150.c ethernet driver : usb_unlink_urb ->usb_kill_urb Eric Valette
2004-09-11 17:33 ` Eric Valette
2004-09-14 18:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41414D73.5080902@free.fr \
--to=eric.valette@free.fr \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=petkan@nucleusys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox