From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Greg KH <greg@kroah.com>,
akpm@osdl.org, bjorn.helgaas@hp.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] missing pci_disable_device()
Date: Fri, 10 Sep 2004 16:58:07 +0900 [thread overview]
Message-ID: <41415E8F.3000404@jp.fujitsu.com> (raw)
In-Reply-To: <1094735472.14640.18.camel@localhost.localdomain>
Alan Cox wrote:
> On Iau, 2004-09-09 at 11:29, Kenji Kaneshige wrote:
>> > dev_warn(&pci_dev->dev, "Device was removed without properly "
>> > "calling pci_disable_device(), please fix.\n");
>> > WARN_ON(1);
>> >
>
> "This may need fixing" would be better than "please fix" as it may be
> a wrong warning
>
Yes.
I should have considered drivers that intentionally don't disable
devices. I'll change the message.
>> I changed my patch based on your feedback. But I have one
>> concern about putting "WARN_ON(1);". I'm worrying that people
>> might be surprised if stack dump is shown on their console,
>> especially if the broken driver handles many devices.
>
> You could put
>
> #ifdef CONFIG_DEBUG_KERNEL
>
> #endif
>
> around that section, then only users selecting kernel debugging would
> be bothered by it.
>
Thank you for advice.
But I don't know if we should take this approach, because
'CONFIG_DEBUG_KERNEL' is set by default on RedHat and some
other distros.
How do you think?
Thanks,
Kenji Kaneshige
next prev parent reply other threads:[~2004-09-10 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 1:26 [PATCH] missing pci_disable_device() Kenji Kaneshige
2004-09-07 9:49 ` Alan Cox
2004-09-08 3:14 ` Kenji Kaneshige
2004-09-08 12:39 ` Alan Cox
2004-09-09 5:55 ` Kenji Kaneshige
2004-09-09 6:20 ` Greg KH
2004-09-09 10:29 ` Kenji Kaneshige
2004-09-09 13:11 ` Alan Cox
2004-09-10 7:58 ` Kenji Kaneshige [this message]
2004-09-09 17:33 ` Greg KH
2004-09-09 19:38 ` Jeff Garzik
2004-09-10 8:18 ` Kenji Kaneshige
2004-09-13 3:55 ` Kenji Kaneshige
2004-09-14 20:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41415E8F.3000404@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bjorn.helgaas@hp.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox