From: Peter Williams <pwil3058@bigpond.net.au>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6.9-rc1-bk14 Oops] In groups_search()
Date: Fri, 10 Sep 2004 18:46:40 +1000 [thread overview]
Message-ID: <414169F0.1040202@bigpond.net.au> (raw)
In-Reply-To: <4141621D.7020301@bigpond.net.au>
Peter Williams wrote:
> Andrew Morton wrote:
>
>>
>> Could you see if this patch fixes the above crash?
>>
>> --- 25/fs/isofs/rock.c~rock-kludge 2004-09-10 00:52:30.394468656 -0700
>> +++ 25-akpm/fs/isofs/rock.c 2004-09-10 00:53:14.544756792 -0700
>> @@ -62,7 +62,7 @@
>> }
>> #define MAYBE_CONTINUE(LABEL,DEV) \
>> - {if (buffer) kfree(buffer); \
>> + {if (buffer) { kfree(buffer); buffer = NULL; } \
>> if (cont_extent){ \
>> int block, offset, offset1; \
>> struct buffer_head * pbh; \
>> _
>>
>>
>> I sure hope it does, so I don't have to look at rock.c again.
>
>
> It does and no sign of the oops or scheduling while atomic messages.
I was mistaken about the schedule while atomic messages. They showed up
again when I did the "make install".
> I
> still have the original four patches applied. I'll try again with an
> unpatched bk16 and let you know the results shortly.
>
With out of the box bk16 plus your rock.c patch and with
CONFIG_DEBUG_SLAB and CONFIG_DEBUG_PAGEALLOC selected I get no oops in
in_groupse_p() or kfree() but I still get the scheduling while atomic
messages when I do "make install".
Peter
--
Peter Williams pwil3058@bigpond.net.au
"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce
next prev parent reply other threads:[~2004-09-10 8:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-09 0:54 [2.6.9-rc1-bk14 Oops] In groups_search() Peter Williams
2004-09-09 8:06 ` Andrew Morton
2004-09-09 23:58 ` Peter Williams
2004-09-10 0:14 ` Andrew Morton
2004-09-10 1:53 ` Peter Williams
2004-09-10 3:06 ` Andrew Morton
2004-09-10 5:45 ` Peter Williams
2004-09-10 6:18 ` Andrew Morton
2004-09-10 6:28 ` Peter Williams
2004-09-10 6:37 ` Tim Hockin
2004-09-10 7:05 ` Peter Williams
2004-09-10 6:52 ` Andrew Morton
2004-09-10 7:43 ` Peter Williams
2004-09-10 7:49 ` Andrew Morton
2004-09-10 7:54 ` Andrew Morton
2004-09-10 8:13 ` Peter Williams
2004-09-10 8:46 ` Peter Williams [this message]
2004-09-10 8:54 ` Andrew Morton
2004-09-10 10:55 ` Peter Williams
2004-09-10 13:04 ` Peter Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414169F0.1040202@bigpond.net.au \
--to=pwil3058@bigpond.net.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox