From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Nikita Danilov <nikita@clusterfs.com>,
Linux Kernel Mailing List <Linux-Kernel@Vger.Kernel.ORG>
Subject: Re: 2.6.9-rc1: page_referenced_one() CPU consumption
Date: Sat, 11 Sep 2004 11:01:37 +1000 [thread overview]
Message-ID: <41424E71.3050107@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.44.0409101315520.16623-100000@localhost.localdomain>
Hugh Dickins wrote:
> On Fri, 10 Sep 2004, Hugh Dickins wrote:
>
>>I'm quite content to go back to a trylock in page_referenced_one - and
>>in try_to_unmap_one? But yours is the first report of an issue there,
>>so I'm inclined to wait for more reports (which should come flooding in
>>now you mention it!), and input from those with a better grasp than I
>>of how vmscan pans out in practice (Andrew, Nick, Con spring to mind).
>
>
> Just want to add, that there'd be little point in changing that back
> to a trylock, if vmscan ends up cycling hopelessly around a larger
> loop - though if the larger loop is more preemptible, that's a plus.
>
Yeah - I'm not sure why a trylock would perform better. If it is just
one big address space, and memory needs to be freed, presumably the
scanner will just choose a different page, and try the lock again.
Feel like doing a few more quick tests Nikita? ;)
next prev parent reply other threads:[~2004-09-11 1:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-10 10:51 2.6.9-rc1: page_referenced_one() CPU consumption Nikita Danilov
2004-09-10 12:14 ` Hugh Dickins
2004-09-10 12:21 ` Hugh Dickins
2004-09-11 1:01 ` Nick Piggin [this message]
2004-09-12 15:53 ` Nikita Danilov
2004-09-13 4:53 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41424E71.3050107@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=Linux-Kernel@Vger.Kernel.ORG \
--cc=hugh@veritas.com \
--cc=nikita@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox