From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965501AbcBQVod (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Feb 2016 16:44:33 -0500
Received: from mout.kundenserver.de ([212.227.126.135]:55822 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965022AbcBQVoc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Feb 2016 16:44:32 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Kees Cook <keescook@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Laura Abbott <laura@labbott.name>, Mark Rutland <mark.rutland@arm.com>,
        Jeremy Linton <jeremy.linton@arm.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lkdtm: add test for executing .rodata
Date: Wed, 17 Feb 2016 22:44:12 +0100
Message-ID: <4143845.Jr27FPv8XS@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20160216214904.GA23723@www.outflux.net>
References: <20160216214904.GA23723@www.outflux.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:j2cwBAuVcRGvIwWiyDKRJVftNkXYYykaL0Dfytr82KHzqOsyvI1
 sOZDvuDvg3KnNYS9ODtaOgBhcf2E7WI28UBrfYDtwW8hrTsgEFsk2A35BfdlBbT/t06V+qI
 p/aw8z3HtPhQJTVuKEveuv6g3fjUkNE4eCqE48sq97MhAgGYsHZDI8bkRi3570hJ/WwCH3v
 qX0GBIy+ary9R2zD3n9gw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:2KezKToBulM=:J0xpwgzbWu+XeUZgmlK7T4
 8Kym0u21o8aI+oh9H5tkAq3prtcF36z7y5XZZyWIUFlsjOPEi1LkXxIdzIB4bbAhrYkVKWpWX
 qHH4xzVl5CpbmVE5POi7Wr7jgVKHRLzNXa5Gra5p+5emw/xVZtIWYxh5OGXT36ZKW8dU8ensA
 WiJZK8rWq7i+plC9tDHHRXsENANn/FTSu9RgTxqYSqjJ1xhPawBTvaSz1lilP4qTcte4lTr04
 AXCxZ/I+TDNFqKig1Z5BnKOFiujReWBDtA+Ut/m33Mm0z1CNzmYc120BuwX0oLFu1NbnU7qd4
 7wHZ/IMaZGbBQ5XnAAW9kQ/aQ0PrlTCnFSYUEo7STLD+7lgKe9NzfaxQwGTWqAVIQIhXa95h4
 6iwQQgb01fr2q8eXc3P+Po8MAoqbmp0lJLNdmwv7K2unie3Vop9ErKF2mr/6/IRbHBn+y2EcW
 f7CB/YkMdECm24QRjfCiQC1yh5ZZejR9yeQy8MhUdKK6VuOLsqHrSlNltwasNUpL07Js5Olr7
 JuUSEk8eP73n/iaNCFz5KxW/szQU/lOBg54jiXlbmuVWsfD3nEe6E8zIWxeZN1IwxSlgvckxG
 TmccuqHap773VP/MNv8z5v72KPhvxg5rOVv985Ju6CD5ttNQuHNpT/7+jfOxFtUcKp32c+Ybt
 TuXi5DIB4z9RveiRgf7e7vDi9elJdcUuB4QTmBjgoNUj7dxHqAKsFomLjbFxZld9c3TdOhoPL
 EblVvH+MqL3iPT/o
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 16 February 2016 13:49:04 Kees Cook wrote:
>  }
>  
> +static void __attribute__((__section__(".rodata,\"a\",@progbits#")))
> +do_nothing_rodata(void)
> +{
> +       return;
> +}
> +
>  static void do_nothing(void)
>  {
> 

I think this also needs to be marked "noinline" to ensure that the
function does not get eliminated. I've seen clang do that on
execute_location() recently and submitted a patch for that.

	Arnd