From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S266646AbUIMNUA@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S266646AbUIMNUA (ORCPT <rfc822;willy@w.ods.org>);
	Mon, 13 Sep 2004 09:20:00 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266689AbUIMNUA
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 13 Sep 2004 09:20:00 -0400
Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:15081 "EHLO
	www.linux.org.uk") by vger.kernel.org with ESMTP id S266646AbUIMNT6
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Sep 2004 09:19:58 -0400
Message-ID: <41459E6E.9020902@pobox.com>
Date: Mon, 13 Sep 2004 09:19:42 -0400
From: Jeff Garzik <jgarzik@pobox.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
       Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sata_svw: Fix __iomem related warnings
References: <1095049642.4536.256.camel@gaston> <20040913093628.A24406@infradead.org>
In-Reply-To: <20040913093628.A24406@infradead.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Christoph Hellwig wrote:
> On Mon, Sep 13, 2004 at 02:27:22PM +1000, Benjamin Herrenschmidt wrote:
> 
>>This patch adds some (ugly) casts to sata_svw to remove the
>>warnings generated by the new iomem stuff.
> 
> 
> Umm, maybe it's just me - but shouldn't you fix them properly?
> 
> 
>>-		writeb(tf->ctl, ioaddr->ctl_addr);
>>+		writeb(tf->ctl, (void __iomem *)ioaddr->ctl_addr);
> 
> 
> e.g. ioaddr->ctl_addr should get a __iomem attribute

Wrong.  Read the code.

	Jeff