From: Neil Horman <nhorman@redhat.com>
To: Felipe W Damasio <felipewd@terra.com.br>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] close race condition in shared memory mapping/unmapping
Date: Mon, 13 Sep 2004 16:54:30 -0400 [thread overview]
Message-ID: <41460906.9080307@redhat.com> (raw)
In-Reply-To: <414607C7.4000801@terra.com.br>
Felipe W Damasio wrote:
> Hi Neil,
>
> Neil Horman wrote:
>
>> + down(&shm_ids.sem);
>> shp = shm_lock(shmid);
>> if(shp == NULL) {
>> + shm_unlock(shp);
>> + up(&shm_ids.sem);
>> err = -EINVAL;
>> goto out;
>> }
>
>
> Trying to unlock a NULL pointer?
>
> Cheers,
>
> Felipe
Crap, good catch. I'll repost with that fixed. Anything else you see a
problem with?
Regards
Neil
--
/***************************************************
*Neil Horman
*Software Engineer
*Red Hat, Inc.
*nhorman@redhat.com
*gpg keyid: 1024D / 0x92A74FA1
*http://pgp.mit.edu
***************************************************/
next prev parent reply other threads:[~2004-09-13 20:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 20:33 [PATCH] close race condition in shared memory mapping/unmapping Neil Horman
2004-09-13 20:49 ` Felipe W Damasio
2004-09-13 20:54 ` Neil Horman [this message]
2004-09-13 21:01 ` Chris Wright
2004-09-14 11:48 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41460906.9080307@redhat.com \
--to=nhorman@redhat.com \
--cc=felipewd@terra.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox