From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jens Axboe <axboe@suse.de>, "C.Y.M." <syphir@syphir.sytes.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Changes to ide-probe.c in 2.6.9-rc2 causing improper detection
Date: Tue, 14 Sep 2004 11:18:21 -0400 [thread overview]
Message-ID: <41470BBD.7060700@pobox.com> (raw)
In-Reply-To: <1095156346.16572.2.camel@localhost.localdomain>
Alan Cox wrote:
> On Maw, 2004-09-14 at 07:06, Jens Axboe wrote:
>
>>Alan, I bet there are a lot of these. Maybe we should consider letting
>>the user manually flag support for FLUSH_CACHE, at least it is in their
>>hands then.
>
>
> You are assuming the drive supports "FLUSH_CACHE" just because it
> doesn't error it. Thats a good way to have accidents.
>
> The patch I posted originally did turn wcache off for barrier if no
> flush cache support was present but had a small bug so that bit got
> dropped.
FWIW the libata test for checking whether it is OK to issue a flush is
return ata_id_wcache_enabled(dev) ||
ata_id_has_flush(dev) ||
ata_id_has_flush_ext(dev);
and if it passes that test,
if ((tf->flags & ATA_TFLAG_LBA48) &&
(ata_id_has_flush_ext(qc->dev)))
tf->command = ATA_CMD_FLUSH_EXT;
else
tf->command = ATA_CMD_FLUSH;
I wouldn't object to removing the "ata_id_wcache_enabled" test if people
feel that it is unsafe.
Jeff
next prev parent reply other threads:[~2004-09-14 15:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 2:26 Changes to ide-probe.c in 2.6.9-rc2 causing improper detection C.Y.M.
2004-09-14 6:06 ` Jens Axboe
2004-09-14 7:03 ` C.Y.M.
2004-09-14 7:06 ` Jens Axboe
2004-09-14 7:15 ` Jens Axboe
2004-09-14 8:20 ` C.Y.M.
2004-09-14 8:28 ` Jens Axboe
2004-09-14 10:09 ` Alan Cox
2004-09-14 11:12 ` Jens Axboe
2004-09-14 10:35 ` Alan Cox
2004-09-14 11:43 ` Jens Axboe
2004-09-14 11:19 ` Alan Cox
2004-09-14 12:21 ` Jens Axboe
2004-09-14 11:37 ` Gene Heskett
2004-09-14 10:07 ` Alan Cox
2004-09-14 11:11 ` Jens Axboe
2004-09-14 11:59 ` Bartlomiej Zolnierkiewicz
2004-09-14 13:15 ` Jens Axboe
2004-09-14 10:05 ` Alan Cox
2004-09-14 11:09 ` Jens Axboe
2004-09-14 12:07 ` Bartlomiej Zolnierkiewicz
2004-09-14 15:18 ` Jeff Garzik [this message]
2004-09-14 15:25 ` Jens Axboe
2004-09-14 15:05 ` Alan Cox
2004-09-14 15:33 ` Mark Lord
2004-09-14 15:39 ` Mark Lord
2004-09-14 15:51 ` Jeff Garzik
2004-09-14 15:06 ` Alan Cox
2004-09-14 15:45 ` Jeff Garzik
2004-09-14 15:31 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41470BBD.7060700@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=syphir@syphir.sytes.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox