From: Mark Lord <lkml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@steeleye.com>
Subject: Re: [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2
Date: Tue, 14 Sep 2004 14:03:28 -0400 [thread overview]
Message-ID: <41473270.3070405@rtr.ca> (raw)
In-Reply-To: <414730D9.3000003@pobox.com>
>The SCSI LLD API really needs to -not- spinlock on the EH hooks,
>and instead simply guarantee that ->queuecommand and other hooks
>will not be called while the driver is in EH.
>
>ISTR James didn't disagree, so maybe a patch can be worked out...
It looks to me as if the eh code prevents further queuecommand()
calls while the LLD *_reset_handler() code is running.
I wonder if it also does so for the eh_strategy_handler() ?
Have to look at it, I guess.
>Of course, you could always just use ->eh_strategy_handler
>and do 100% of the error handling yourself.
Mmmm.. yes, that may be better, perhaps.
Whatever this driver does, it has to be reasonably portable
back to early 2.4.xx kernels, so it cannot depend too much
upon newly (or to-be) implemented semantics in 2.6.xx.
Cheers
--
Mark Lord
(hdparm keeper & the original "Linux IDE Guy")
next prev parent reply other threads:[~2004-09-14 18:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 15:42 [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2 Mark Lord
2004-09-14 16:00 ` Alan Cox
2004-09-14 17:14 ` Mark Lord
2004-09-14 17:00 ` Jeff Garzik
2004-09-14 17:27 ` Mark Lord
2004-09-14 17:33 ` Jeff Garzik
2004-09-14 17:51 ` Mark Lord
2004-09-14 17:56 ` Jeff Garzik
2004-09-14 18:03 ` Mark Lord [this message]
2004-09-14 18:07 ` Jeff Garzik
2004-09-14 18:08 ` Jeff Garzik
2004-09-14 18:25 ` James Bottomley
2004-09-14 18:35 ` Jeff Garzik
2004-09-14 18:51 ` James Bottomley
2004-09-15 2:39 ` Mark Lord
2004-09-15 2:47 ` Jeff Garzik
2004-09-15 12:35 ` Mark Lord
[not found] <414711AC.5030200@rtr.ca>
[not found] ` <41471A84.4090200@pobox.com>
[not found] ` <4147C38C.3000104@torque.net>
[not found] ` <414839F0.20008@rtr.ca>
2004-09-15 17:01 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41473270.3070405@rtr.ca \
--to=lkml@rtr.ca \
--cc=James.Bottomley@steeleye.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox