From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Li Shaohua <shaohua.li@intel.com>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@redhat.com>
Subject: Re: hotplug e1000 failed after 32 times
Date: Fri, 17 Sep 2004 19:34:08 -0400 [thread overview]
Message-ID: <414B7470.4000703@pobox.com> (raw)
In-Reply-To: <20040917161920.16d18333.akpm@osdl.org>
All this work and code for such an uncommon case??
First off, any settings which are _indexed_ are almost guaranteed
broken. For reasons as we see here, and others. Any
"setting_foo[board_number]" should be found and eliminated instead.
Even if you allocate and free board numbers as described, how precisely
do you propose to predict which settings belong to which hotplugged
board? Look at the problem, and you realize that the board<->setting
association becomes effectively _random_ for any adapter not present at
modprobe time.
The best model is to set these settings via netlink/ethtool after
registering the interface, but before bringing it up.
Jeff
next prev parent reply other threads:[~2004-09-17 23:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-17 4:53 hotplug e1000 failed after 32 times Li Shaohua
2004-09-17 5:14 ` Andrew Morton
2004-09-17 5:48 ` Li Shaohua
2004-09-17 9:05 ` Li Shaohua
2004-09-17 23:19 ` Andrew Morton
2004-09-17 23:34 ` Jeff Garzik [this message]
2004-09-19 16:04 ` Jonathan Lundell
2004-09-19 16:50 ` Dr. David Alan Gilbert
2004-09-20 0:30 ` Jonathan Lundell
2004-09-20 0:51 ` Li Shaohua
2004-09-20 2:55 ` Jeff Garzik
2004-09-20 4:15 ` Chris Leech
2004-09-20 4:35 ` Li Shaohua
2004-09-17 9:06 ` Li Shaohua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414B7470.4000703@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox