public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlos Eduardo Medaglia Dyonisio <medaglia@undl.org.br>
To: linux-kernel@vger.kernel.org
Cc: medaglia@undl.org.br
Subject: [PATCH][2.6.9-rc2] Fix types.h
Date: Sat, 18 Sep 2004 14:27:24 -0300	[thread overview]
Message-ID: <414C6FFC.6060604@undl.org.br> (raw)

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

Hi!

This patch fixes troubles when compiling some applications that include 
<linux/byteorder/little_endian.h>, like xmms. When I was compiling xmms 
I've got:
In file included from /usr/include/asm/byteorder.h:57,
                  from /usr/include/linux/cdrom.h:14,
                  from cdaudio.h:60,
                  from cdaudio.c:21:
/usr/include/linux/byteorder/little_endian.h:43: error: parse error 
before "__cpu_to_le64p"
/usr/include/linux/byteorder/little_endian.h: In function `__cpu_to_le64p':
/usr/include/linux/byteorder/little_endian.h:45: error: `__le64' 
undeclared (first use in this function)
...etc...

I've put the __le(16|32|64) and __be(16|32|64) typedefs out of #ifndef 
__KERNEL_STRICT_NAMES and now everything is working. Xmms is compiling 
fine, and linux kernel too. :)

Maybe I made something wrong, because this is my first patch to linux 
kernel... But everything is working fine for me.

Regards,
Cadu

[-- Attachment #2: patch-types.h.diff --]
[-- Type: text/plain, Size: 790 bytes --]

--- linux-2.6.9-rc2/include/linux/types.h	2004-09-13 02:33:23.000000000 -0300
+++ linux/include/linux/types.h	2004-09-18 14:16:27.000000000 -0300
@@ -140,6 +140,13 @@
 #define pgoff_t unsigned long
 #endif
 
+#endif /* __KERNEL_STRICT_NAMES */
+
+/*
+ * Below are truly Linux-specific types that should never collide with
+ * any application/library that wants linux/types.h.
+ */
+
 #ifdef __CHECKER__
 #define __bitwise __attribute__((bitwise))
 #else
@@ -153,13 +160,6 @@
 typedef __u64 __bitwise __le64;
 typedef __u64 __bitwise __be64;
 
-#endif /* __KERNEL_STRICT_NAMES */
-
-/*
- * Below are truly Linux-specific types that should never collide with
- * any application/library that wants linux/types.h.
- */
-
 struct ustat {
 	__kernel_daddr_t	f_tfree;
 	__kernel_ino_t		f_tinode;

             reply	other threads:[~2004-09-18 17:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-18 17:27 Carlos Eduardo Medaglia Dyonisio [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-09-23  0:29 [PATCH][2.6.9-rc2] Fix types.h Carlos Eduardo Medaglia Dyonisio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=414C6FFC.6060604@undl.org.br \
    --to=medaglia@undl.org.br \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox