public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Helge Hafting <helge.hafting@hist.no>
To: Herbert Poetzl <herbert@13thfloor.at>
Cc: Olaf Hering <olh@suse.de>, DervishD <lkml@dervishd.net>,
	Andries.Brouwer@cwi.nl, linux-kernel@vger.kernel.org
Subject: Re: OOM & [OT] util-linux-2.12e
Date: Tue, 21 Sep 2004 09:20:04 +0200	[thread overview]
Message-ID: <414FD624.7050603@hist.no> (raw)
In-Reply-To: <20040920141256.GB601@MAIL.13thfloor.at>

Herbert Poetzl wrote:

>On Mon, Sep 20, 2004 at 03:32:59PM +0200, Helge Hafting wrote:
>  
>
>>Olaf Hering wrote:
>>
>>    
>>
>>>On Mon, Sep 20, Helge Hafting wrote:
>>>
>>>      
>>>
>>>>Using a mtab that is a link to /proc/mounts fails with quota too.
>>>>Quta tools read /etc/mtab looking for "usrquota" and or "grpquota"
>>>>mount options.  These appear in a normal /etc/mtab but not in 
>>>>/proc/mounts,
>>>>        
>>>>
>>>I have never played with quota. But: does the kernel or a userland tool
>>>if quota is active for a mount point? smells like a kernel bug.
>>>      
>>>
>
>- to make the quota active (enable it), the mount option
>  is required
>
>- to display an enabled quota as mount option, the quota
>  on that 'mount point' has to be enabled 
>
>chicken egg thing, eh?
>  
>
Chicken egg by design perhaps, but I can't see
why it have to be that way.

>besides that, not every mountpoint can support quota
>and quota should (must) not be enabled at mount time
>because before the quota is enabled, the quota hash
>has to be initialized to the current usage ...
>  
>
A better way:
Enable the quota at mount time.  If the system isn't ready
for that, i.e. the quota files aren't created/updated - then
refuse the mount.  (Alternatively, mount without quota and
log a complaint.) The administrator can then mount
without quota, run checkquota, and  mount /fs -o remount,usrquota
to turn quota on.

In other words:
quotaon becomes mount -o remount,usrquota
quotaoff becomes mount -o remount,nousrquota
(And/or grpquota of course)

Does it have to be any more complicated than that?


>>Doing it at mount time instead, byt actually using those options,
>>seems saner to me.  But I guess they had their reasons. . .
>>    
>>
>
>yes, quota calculation, see above ...
>  
>
What I don't get is why we have to mount with quota options
that aren't acutally used, and then turn quota on.
Why not mount without quota, and then remount with
quota options when enabling quota for the first time?

The common case should be a fs that was shut down
cleanly and was mounted with quota the last time it
was used.  So it should be able to mount directly
with quota on, because all the on-disk quota information
is valid and up to date.

Helge Hafting



  reply	other threads:[~2004-09-21  7:15 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-19 22:05 OOM & [OT] util-linux-2.12e Andries.Brouwer
2004-09-20  9:46 ` Olaf Hering
2004-09-20 10:12   ` Andreas Schwab
2004-09-20 10:54     ` DervishD
2004-09-20 11:43       ` Andreas Schwab
2004-09-20 11:51         ` Paulo Marques
2004-09-20 12:11           ` DervishD
2004-09-20 12:14           ` Andreas Schwab
2004-09-20 12:00         ` DervishD
2004-09-20 10:23   ` Roman Zippel
2004-09-20 10:56     ` Olaf Hering
2004-09-20 11:16       ` Roman Zippel
2004-09-20 11:26         ` Olaf Hering
2004-09-20 11:38           ` Roman Zippel
2004-09-20 11:50             ` Olaf Hering
2004-09-20 12:02               ` Roman Zippel
2004-09-20 12:07                 ` Olaf Hering
2004-09-20 12:14                   ` Roman Zippel
2004-09-20 12:19                     ` Olaf Hering
2004-09-20 12:34                       ` Roman Zippel
2004-09-20 12:38                         ` Olaf Hering
2004-09-20 12:51                           ` Andreas Schwab
2004-09-20 12:54                             ` Olaf Hering
2004-09-20 13:19             ` CaT
2004-09-20 13:33               ` Andreas Schwab
2004-09-20 13:15     ` CaT
2004-09-20 10:59   ` DervishD
2004-09-20 13:24     ` Helge Hafting
2004-09-20 13:21       ` Olaf Hering
2004-09-20 13:32         ` Helge Hafting
2004-09-20 14:12           ` Herbert Poetzl
2004-09-21  7:20             ` Helge Hafting [this message]
2004-09-21  9:18               ` Herbert Poetzl
2004-09-20 15:24     ` Tonnerre
2004-09-20 11:11   ` David Gómez
2004-09-20 11:06 ` DervishD
2004-09-20 11:38   ` Xavier Bestel
2004-09-20 11:59     ` DervishD
2004-09-20 12:32       ` Xavier Bestel
2004-09-20 14:16         ` Herbert Poetzl
2004-09-21 16:45 ` Jari Ruusu
2004-09-21 21:26   ` Andries Brouwer
2004-09-22 17:05     ` Jari Ruusu
2004-09-22 18:39       ` Andries Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=414FD624.7050603@hist.no \
    --to=helge.hafting@hist.no \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=herbert@13thfloor.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@dervishd.net \
    --cc=olh@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox