public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] MMC compatibility fix - GO_IDLE
Date: Wed, 22 Sep 2004 19:45:35 +0200	[thread overview]
Message-ID: <4151BA3F.8040406@drzeus.cx> (raw)
In-Reply-To: <20040922151735.D2347@flint.arm.linux.org.uk>

Russell King wrote:

>On Sat, Sep 18, 2004 at 11:56:42AM +0200, Pierre Ossman wrote:
>  
>
>>This patch adds a GO_IDLE before sending a new SEND_OP_COND (as required 
>>by MMC standard).
>>    
>>
>
>Thanks; I haven't completely vanished off the face of the planet.
>  
>
Good to know. You've seemed a bit busy :)

>We already have a function using MMC_GO_IDLE_STATE, so I suggest we
>separate this out.  If you need a 1ms delay after sending this, maybe
>the other case also needs this delay as well?
>
>  
>
The delay was added just in case. The cards I have here work fine 
without it. I just thought adding a small delay might avoid problematic 
cards later on. Seems to be a few of those.

>How about this patch?
>
>  
>
Looks ok. You sure we don't need to put all cards into an idle state 
before issuing a new SEND_OP_COND? I haven't studied how the MMC layer 
is called in detail. Can a rescan be done while a card is in a selected 
state?

Rgds
Pierre


  reply	other threads:[~2004-09-22 17:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-18  9:56 [PATCH 1/3] MMC compatibility fix - GO_IDLE Pierre Ossman
2004-09-22 14:17 ` Russell King
2004-09-22 17:45   ` Pierre Ossman [this message]
2004-09-22 19:15     ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4151BA3F.8040406@drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox