From: Grzegorz Piotr Jaskiewicz <gj@pointblue.com.pl>
To: Andrew Morton <akpm@osdl.org>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3] compilation fixes for gcc 4.0
Date: Wed, 22 Sep 2004 21:19:25 +0200 [thread overview]
Message-ID: <4151D03D.4030506@pointblue.com.pl> (raw)
gcc 4.0 doesn't treat this extension as valid anymore.
one of the gcc guys said to me:
" For that matter, they could neatly avoid the whole issue by writing ANSI/ISO-compliant code instead of
using GCC extensions."
That should be sufficient for explanation.
In all these cases, I see no reason to declare prototype inside body of function.
It makes code less readable.
I am sure it's present in few more places, but that's the only place where I can spot it.
Please apply.
Signed-off-by: Grzegorz Jaskiewicz <gj at pointblue.com.pl>
--- drivers/input/joystick/grip_mp.c 2004-08-14 07:37:42 +0200
+++ /tmp/grip_mp.c 2004-09-22 20:58:40 +0200
@@ -107,6 +107,8 @@
static int axis_map[] = { 5, 9, 1, 5, 6, 10, 2, 6, 4, 8, 0, 4, 5, 9, 1,
5 };
+static void register_slot(int i, struct grip_mp *grip);
+
/*
* Returns whether an odd or even number of bits are on in pkt.
*/
@@ -355,7 +357,6 @@
u32 packet;
int joytype = 0;
int slot = 0;
- static void register_slot(int i, struct grip_mp *grip);
/* Get a packet and check for validity */
next reply other threads:[~2004-09-22 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-22 19:19 Grzegorz Piotr Jaskiewicz [this message]
2004-09-23 1:58 ` [PATCH 1/3] compilation fixes for gcc 4.0 Grzegorz Piotr Jaskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4151D03D.4030506@pointblue.com.pl \
--to=gj@pointblue.com.pl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox