From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757810AbbJ2Vqp (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Oct 2015 17:46:45 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:61746 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756994AbbJ2Vqm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Oct 2015 17:46:42 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Michael Welling <mwelling@ieee.org>
Cc: kbuild test robot <lkp@intel.com>, kbuild-all@01.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Tony Lindgren <tony@atomide.com>, Pavel Machek <pavel@ucw.cz>,
        Felipe Balbi <balbi@ti.com>, Sebastian Reichel <sre@kernel.org>,
        Roger Quadros <rogerq@ti.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004
Date: Thu, 29 Oct 2015 22:46:20 +0100
Message-ID: <4152426.STHOuGxqsW@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20151029142237.GA11531@qwerty.qwertyembedded>
References: <1446077554-19684-1-git-send-email-mwelling@ieee.org> <201510291514.OprNyiZf%fengguang.wu@intel.com> <20151029142237.GA11531@qwerty.qwertyembedded>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:TH3PAOT4hDdh7fWKXsBNyIQpZ9eVO4sBuhyC6EDAqF9HtbaPla6
 qTHsUwAMVpB4fhLvgQycI1Fj957Qs2YIvtAegYpslgvZnuBMU+9jPYBWuCR9aK+dWvAf6tM
 bSneK+0W5uzCPo8tSwAlAM3GjF4RQYLYyOIbkcnL6TXHeatxXkVhDJXl4KhGpyfsPWeSY4B
 c5EnALhJlsIt2nb1igN5A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:x5rWv6BXOpo=:aOQNLHzza/qo03iWOGS/K2
 DwGmOkszZEFRpyJ+kvgRkRZKMzGBCSL9hp8BBhQ9Ts7Pb9JO3nyb+w5tgy9xVxlz3cPNwfah4
 D9hdXA6v8sNMf0IynAaMlON//jwlyh3dxIsJtzc8HFtnwCPWSb4pSafmvl4rs/iiwPmw/9HYL
 kuWyp/Ao0jY3/M8U8Y61xvIP13nEz5AayjvJzVmgisyITFGv164wWfSiuKiBVM1p/gUXxdoVU
 FcU1Ye/0TFi4CZkzUNuu707z0GUKYo0fucn6rI4I9KPXPTiOaYvluXNVn/9kpeCKKxaLiqS+f
 /RFLKhCxIRZsm1KADINwLuIRl5wFJ9tXLF72VdcMuF7PtVRXkKfslvniB5voivTwYVJ2kXNC6
 CxGdLD0dAbNcBq6hzgEbQs+6ybc6UXQt860xpgAsUU7LSf4JWAvWQVUSB/HOqWOPF4MgghoJF
 fJmAy7mFqM2NSTUACutQrbCeUetHVDvX04mWxBflxneSdtr+BdNinNh3QgFpScJpXLnzvEJGk
 Dv2zLq95HlQCZwdoKprl9W1hGuqj3PGMjsHzqesY/Du3oxJyh1uMRDuhv7kaZMv3DmfgibgMo
 DRNl39ZAHhSL8azPtgiUA1FFiACjFM0N5R55VbwAyFxDA2t4bSDDVeVHIZc3G89m47AWX8Xtk
 UvF+/0raFfap87JbFDIOFBCSYf/VRiIaQNpjCH2Nea+IBrpTodZL6Y0/IyPoZaSW2Er8BuFdf
 yH41gQGUyHaeMDag
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 29 October 2015 09:22:37 Michael Welling wrote:
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/built-in.o: In function `tsc2005_cmd':
> > >> tsc200x-core.c:(.text+0x2ae07f): undefined reference to `i2c_smbus_write_byte'
> 
> Argh!
> 
> How do I fix this one?
> 

Move all the I2C specific code into the tsc2004.c file and remove the
#ifdef. The problem is that tsc200x-core.c is used as built-in when
TOUCHSCREEN_TSC2005=y and I2C=m, so it can't call functions that are
defined in i2c-core.c.

	Arnd